New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #4206 - Introduces fgRun and fgRunMain #4216

Merged
merged 1 commit into from Jun 20, 2018

Conversation

Projects
None yet
3 participants
@agaro1121
Contributor

agaro1121 commented Jun 19, 2018

Fixes #4206

  • adds fgRun to work like the run command in 0.13
  • adds fgRunMain to work like the runMain command in 0.13
@lightbend-cla-validator

This comment has been minimized.

lightbend-cla-validator commented Jun 19, 2018

Hi @agaro1121,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Jun 20, 2018

@agaro1121 Thanks for the contribution. Please comment when you signed the CLA.

@agaro1121

This comment has been minimized.

Contributor

agaro1121 commented Jun 20, 2018

Happy to contribute @eed3si9n !
I signed the CLA

@eed3si9n

LGTM

@eed3si9n eed3si9n merged commit 56d41ae into sbt:1.x Jun 20, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the ready label Jun 20, 2018

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Jun 27, 2018

@agaro1121 We made a survey form to collect feedback on the contribution process. Please fill it out when get you get a minute. https://goo.gl/forms/LDPlTl9Wso7YwEri2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment