New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CTRL-C exception #4226

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@driquelme
Contributor

driquelme commented Jun 22, 2018

ref: #4197

Adds a shutdown hook in the forked jvm that calls done when a jvm shutdown is requested .
For successful terminating tests, the hook is removed so that done is not called twice.

@eed3si9n eed3si9n added the ready label Jun 22, 2018

@eed3si9n

LGTM
Thanks!

@eed3si9n eed3si9n merged commit 0c3a458 into sbt:1.x Jun 26, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n added hackathon and removed ready labels Jun 26, 2018

@eed3si9n

This comment has been minimized.

Member

eed3si9n commented Jun 27, 2018

We made a survey form to collect feedback on the contribution process. Please fill it out when get you get a minute. https://goo.gl/forms/LDPlTl9Wso7YwEri2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment