New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use val instead of var #4253

Merged
merged 1 commit into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@xuwei-k
Member

xuwei-k commented Jul 8, 2018

@eed3si9n eed3si9n added the in progress label Jul 8, 2018

private[this] var running = new AtomicInteger
private[this] var cancel = new AtomicBoolean(false)
private[this] val running = new AtomicInteger
private[this] val cancel = new AtomicBoolean(false)

This comment has been minimized.

@hepin1989
@hepin1989

hepin1989 Jul 9, 2018

nice

@eed3si9n eed3si9n merged commit cd05720 into sbt:1.x Jul 9, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@eed3si9n eed3si9n removed the in progress label Jul 9, 2018

@xuwei-k xuwei-k deleted the xuwei-k:INode-var branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment