XSBT-5: maven-style ivy repo support in the launcher config #585

Closed
wants to merge 1 commit into from

2 participants

@ebowman

Change-Id: I22c1ff126961d61d92e2e45a5b7eff329d3def90
Reviewed-on: https://gerrit.gilt.com/10950
Reviewed-by: Eric Bowman ebowman@gilt.com
Tested-by: Eric Bowman ebowman@gilt.com

@ebowman ebowman XSBT-5: maven-style ivy repo support in the launcher config
Change-Id: I22c1ff126961d61d92e2e45a5b7eff329d3def90
Reviewed-on: https://gerrit.gilt.com/10950
Reviewed-by: Eric Bowman <ebowman@gilt.com>
Tested-by: Eric Bowman <ebowman@gilt.com>
6cee040
@harrah

Perhaps simplest to delegate to Tuple3 here? Something like:

def hashCode = (ivyPatterns, artifactPatterns, isMavenCompatible).hashCode

I will merge and then make this change myself if you agree.

That's a good trick, no issue here. Thanks.

Also: toString in retrospect is very verbose.

@harrah
sbt member

I will need to make a follow up commit to preserve launcher compatibility (so that an older launcher can be used) and perhaps change hashCode to delegate to Tuple3 if you agree, but it looks good otherwise.

@harrah
sbt member

Merged in 835ee0d and fixed up in e532d20. Thanks!

@harrah harrah closed this Oct 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment