[2.x] refactor: Remove useCoursier setting (drop Ivy)#7712
Merged
Conversation
**Problem** It's been a while since Coursier has been the default library management engine, and we don't need to support two. **Solution** This removes `useCoursier` setting.
adpi2
reviewed
Oct 2, 2024
| @cacheLevel(include = Array.empty) | ||
| val bspReporter = taskKey[BuildServerReporter]("").withRank(DTask) | ||
|
|
||
| val useCoursier = settingKey[Boolean]("Use Coursier for dependency resolution.").withRank(BSetting) |
Member
There was a problem hiding this comment.
Is there any other key that was Ivy specific?
Member
Author
There was a problem hiding this comment.
It seems like there are some internal Ivy usage, but I could probably drop the external ivy.xml file support - 968bd9c
BillyAutrey
reviewed
Oct 2, 2024
BillyAutrey
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
It's been a while since Coursier has been the default library management engine, and we don't need to support two.
Solution
This removes
useCoursiersetting.