Repository navigation
[2.x] Remove instances of Info and BasicAttributeMap - #7882
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task,InfoandBasicAttributeMapcorresponds to 11% of all the living instances in the heap after loading.The main idea of this PR is to remove the instances of
Info, by mergingInfoinTask, and the instances ofBasicAttributeMapby making it an opaque type. Additionally I explicited thatTaskuses reference equality (its not a case class anymore) and I removedStructure.taskKeywhich is not used anywhere, neither internally nor in any sbt 1.x plugin.Result: