Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tasks stuck with sbt 1.0 #346

Closed
sean-liang opened this issue Aug 27, 2017 · 10 comments

Comments

Projects
None yet
5 participants
@sean-liang
Copy link

commented Aug 27, 2017

When sbteclipse plugin is installed, tasks like compile, console will stuck in sbt 1.0.

Environments:
Mac OS 10.12.6
Java 1.8.0_101
scala 2.12.3
sbt 1.0

build.sbt:

organization := "sbteclipse-test"

scalaVersion := "2.12.3"

version := "0.0.1-SNAPSHOT"

EclipseKeys.withSource := true

project/plugins.sbt

addSbtPlugin("com.typesafe.sbteclipse" % "sbteclipse-plugin" % "5.2.1")

project/build.properties

sbt.version=1.0.0
@wks

This comment has been minimized.

Copy link

commented Sep 4, 2017

I can confirm this bug. In my project, sbt stuck after compile, but the problem disappears if I removed project/*.sbt which contains the addSbtPlugin for sbteclipse-plugin.

@dmassart

This comment has been minimized.

Copy link

commented Sep 4, 2017

I experience the problem too. It disappears when downgrading to sbt.version=0.13.15 in project/build.properties

@benmccann

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@godenji any ideas on this one?

@godenji

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

any ideas on this one?

Not yet, just tried sample project on 1.0.0 and 1.0.1 and it hung as advertised. inspect compile differs between 1.0 and 0.13; not sure what's causing the hang, debug log reveals nothing obvious.

@godenji

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

It's the Play Java hack, removing that from 1.0 source fixes the issue.

Will try to sort out hanging console while preserving this "feature", but at least we know where the problem is now.

godenji added a commit to godenji/sbteclipse that referenced this issue Sep 5, 2017

@godenji

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@benmccann fixed in #347

@benmccann

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

Thanks @godenji !!

I've released 5.2.2 with your fix

@benmccann benmccann closed this Sep 5, 2017

@godenji

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

@benmccann awesome, just pulled in 5.2.2 to test project, hanging console gone.

Now wait for sbt 1.0 support to land in Play -- hopefully soon, 0.13 is horrendous on many levels.

@benmccann

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

Is sbt 1.0 much better? I'm not really familiar with what changed

@godenji

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2017

Highlights for me are Scala 2.12 support in the build, and improved incremental compilation (which is an absolute productivity killer in 0.13 with large multi-subproject builds).

This is only important for Scala users of course, Java devs are largely insulated from the pain that sbt inflicts on its users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.