New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk 7 compatibility #75

Closed
peiyuwang opened this Issue Apr 3, 2017 · 1 comment

Comments

Projects
None yet
2 participants
@peiyuwang

peiyuwang commented Apr 3, 2017

Starting 2573c0f , util-interface is compiled/published using jdk8, which means in order to consume zinc >= 1.0.0-X7 we would have to start telling pants users stop using jdk7, which i guess is not totally unreasonable given jdk7 reaches its eol for already 2 years? but honestly i don't know.

Would really appreciate we start with a plan and communicate first whichever decision we choose as opposed to drop immediately.

peiyuwang added a commit to pantsbuild/pants that referenced this issue Apr 4, 2017

Upgrade zinc to `1.0.0-X7` (python portion) (#4419)
### Problem

Notable change in `1.0.0-X7`: sbt/zinc@a25d135 to fix zinc swallow javac error messages.

Two zinc `TODO`s that we should push upstream before next upgrade are:

* sbt/util#75 to generate machine independent analysis file. So we don't have to do the extra work in this PR decode/encode `classpath hash`.
* sbt/zinc#218 jdk 7 compatibility. If zinc decide to discontinue jdk7 support we should start to communicate with pants users. Since the incompatibility is already introduced, this PR has to exclude the jdk8 compiled deps.

### Solution

Upgrade and workarounds of these two TODOs, see comments inline.

### Result

Passed travis

lenucksi added a commit to lenucksi/pants that referenced this issue Apr 25, 2017

Upgrade zinc to `1.0.0-X7` (python portion) (#4419)
### Problem

Notable change in `1.0.0-X7`: sbt/zinc@a25d135 to fix zinc swallow javac error messages.

Two zinc `TODO`s that we should push upstream before next upgrade are:

* sbt/util#75 to generate machine independent analysis file. So we don't have to do the extra work in this PR decode/encode `classpath hash`.
* sbt/zinc#218 jdk 7 compatibility. If zinc decide to discontinue jdk7 support we should start to communicate with pants users. Since the incompatibility is already introduced, this PR has to exclude the jdk8 compiled deps.

### Solution

Upgrade and workarounds of these two TODOs, see comments inline.

### Result

Passed travis
@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Jul 25, 2017

Member

sbt 1 modules will all be built using JDK 8.

Member

eed3si9n commented Jul 25, 2017

sbt 1 modules will all be built using JDK 8.

@eed3si9n eed3si9n closed this Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment