Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Disable ivy log4j caller location calculation #132
This is a reworking of #131 which is getting closer to the root cause of issue: If you look a little closer at sbt/sbt#3711 you can see that most time is spent calculating the caller location for the async logger.
AFAICS the caller location is never displayed anywhere so it can be discarded.
https://issues.apache.org/jira/browse/LOG4J2-153 however indicates this information should be constructed lazily, so I'm still a little puzzled why this takes so long.
I also added a unit test which allows you to easily test the performance of the logging method.
On my machine logging 100k messages takes 5331ms with calculating location and 204ms without, so the gains are substantial.
Are there any general performance benchmarks akin to https://developer.lightbend.com/blog/2017-06-12-faster-scala-compiler/ in place?
I still would say that it's a good idea to keep your previous patch and moreover move it one level up, into
Also thank you for this.