New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In initStringCodecs avoid reflect universe initialization #153

Merged
merged 1 commit into from Feb 19, 2018

Conversation

Projects
None yet
3 participants
@jrudolph
Member

jrudolph commented Feb 19, 2018

This showed up in profiling. It's known that TypeTags are expensive. Even
more so if the reflect universe is accessed during startup when the
class loading and JIT compiler are busy enough with other stuff.

In initStringCodecs avoid reflect universe initialization
This showed up in profiling. It's known that TypeTags are expensive. Even
more so if the reflect universe is accessed during startup when the
class loading and JIT compiler are busy enough with other stuff.

@eed3si9n eed3si9n added the ready label Feb 19, 2018

@dwijnand

This comment has been minimized.

Member

dwijnand commented Feb 19, 2018

Thanks @jrudolph.

@dwijnand dwijnand merged commit 85f7d80 into sbt:1.x Feb 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dwijnand dwijnand removed the ready label Feb 19, 2018

dwijnand added a commit to dwijnand/sbt-util that referenced this pull request Apr 5, 2018

Enforce invariant in StringTypeTag optimisation
Or, put differently, "Add a test for sbt#153".

@eed3si9n eed3si9n referenced this pull request Aug 1, 2018

Merged

build sbt 1.2.0 #758

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment