New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripted doesn't support multiprojects #84

Closed
gkossakowski opened this Issue Mar 17, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@gkossakowski
Contributor

gkossakowski commented Mar 17, 2016

This doesn't let us test multi-project support in incremental compiler.

Maybe the solution would be to port such tests to be a plain code that calls into IncHandler directly?

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Mar 17, 2016

Member

In the long run maybe we should run some integration test that runs sbt with freshly compiled zinc:

  1. so we can check that zinc didn't break API points for sbt.
  2. and be able to run more sophisticated scripted tests
Member

eed3si9n commented Mar 17, 2016

In the long run maybe we should run some integration test that runs sbt with freshly compiled zinc:

  1. so we can check that zinc didn't break API points for sbt.
  2. and be able to run more sophisticated scripted tests

gkossakowski added a commit that referenced this issue Mar 17, 2016

@gkossakowski

This comment has been minimized.

Show comment
Hide comment
@gkossakowski

gkossakowski Mar 17, 2016

Contributor

This is a pretty good idea on its own but I'd like something more lightweight for testing multi-project support that has a fast turnaround time. Those tests should be really fast to run.

Fast turnaround was my original motivation for introducing specs2-based tests as an alternative to scripted tests.

Contributor

gkossakowski commented Mar 17, 2016

This is a pretty good idea on its own but I'd like something more lightweight for testing multi-project support that has a fast turnaround time. Those tests should be really fast to run.

Fast turnaround was my original motivation for introducing specs2-based tests as an alternative to scripted tests.

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Oct 26, 2017

Member

Multi project support was already implemented and nobody closed this ticket. An example is subproject-dependency. Here's the proof:

{
  "projects": [
    {
      "name": "use",
      "dependsOn": ["dep"]
    },
    {
      "name": "dep"
    }
  ]
}

Unless I'm missing something, this is done. I'm closing it, feel free to reopen if I'm wrong or the motivation of this ticket was different than the multi-project support I refer to.

Member

jvican commented Oct 26, 2017

Multi project support was already implemented and nobody closed this ticket. An example is subproject-dependency. Here's the proof:

{
  "projects": [
    {
      "name": "use",
      "dependsOn": ["dep"]
    },
    {
      "name": "dep"
    }
  ]
}

Unless I'm missing something, this is done. I'm closing it, feel free to reopen if I'm wrong or the motivation of this ticket was different than the multi-project support I refer to.

@eed3si9n

This comment has been minimized.

Show comment
Hide comment
@eed3si9n

eed3si9n Oct 26, 2017

Member

Yes. I fixed in #208, but didn't close it.

Member

eed3si9n commented Oct 26, 2017

Yes. I fixed in #208, but didn't close it.

@jvican jvican removed the spree label Oct 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment