Include internal dependency in extraHash
computation
#1290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
PR #1289 addressed under-compilation for traits with transitive external inheritance dependencies by propagating
TraitPrivateMembersModified
from parent trait to child traits.However, when the hierarchy consists a mix of internal & external dependencies,
TraitPrivateMembersModified
would fail to propagate, resulting in under compilation.For example, say
c.C -> b.B -> a.A
, (c.C
extendsc.B
,c.B
extendsa.A
), for whichc.C
andc.B, a.A
are on different projects, then whena.A
's private member is changed, the propagation stops atc.B
since computation ofc.B
'sextraHash
only takes account ofa.A
's external dependency, whilea.A
is part ofc.B
's internal dependency. Hencec.C
never gets recompiled.Fix
Include internal dependency in
extraHash
computation.