Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scala-xml to 2.3.0 #1355

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates org.scala-lang.modules:scala-xml from 2.2.0 to 2.3.0

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (2.2.0).
You might want to review and update them manually.

project/plugins.sbt
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scala-lang.modules", artifactId = "scala-xml" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "org.scala-lang.modules", artifactId = "scala-xml" }
}]
labels: library-update, early-semver-minor, semver-spec-minor, version-scheme:early-semver, old-version-remains, commit-count:1

@xuwei-k xuwei-k merged commit 7401e0b into sbt:develop Apr 27, 2024
8 checks passed
@eed3si9n
Copy link
Member

See sbt/sbt#7564.

I don't know if we should use Scala Steward for Zinc since any change to version usually have some consequence.

@SethTisue
Copy link
Member

SethTisue commented May 20, 2024

I agree that I should have given more thought to this PR before approving it. That's on me. But I think the Steward PRs are valuable to have regardless, since they notify us when potential upgrades exist that should be considered.

In my opinion, it should work for zinc to have a newer scala-xml dependency than scala-compiler does, as long as the versions are binary compatible. (And unless it's too difficult to achieve, I suppose.) Let's discuss further on 7654

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants