Add MultiProjectIncrementalSpec to test shadowing detection #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref #166 There are two subprojects sub1 and sub2. sub1 depends on sub2. The test consists of three phases: 1. sub1 is compiled with `src/Depender.scala`, and uses empty `sub2/target/` directory and `lib/sample-binary_2.11-0.1.jar` as the classpath. Depender calls `test.pkg.Ext1.x`, which is defined in the JAR file. 2. Next, sub2 is compiled with `src/Ext1.scala`. 3. sub1 is compiled again with `src/Good.scala`. This should detect that `test.pkg.Ext1` is now shadowed by `sub2/target`, and thus `src/Depender.scala` must be invalidated.
This change is to test `externalBinaryModified`'s ability to detect shadowing when there are more than one class name involved per JAR file.
|
Should you mark your test as pending and then mark it as passing in #180? Otherwise, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #166
This is on top of #176
Instead of the virtual project, this uses actual files and JAR to test the shadowing detection.
steps
There are two subprojects sub1 and sub2. sub1 depends on sub2. The test consists of three phases:
src/Depender.scala, and uses emptysub2/target/directory andlib/sample-binary_2.11-0.1.jaras the classpath.Dependercallstest.pkg.Ext1.x, which is defined in the JAR file.src/Depender.scalaandsrc/Depender2.scala, and uses emptysub2/target/directory andlib/sample-binary_2.11-0.1.jaras the classpath.Depender2callstest.pkg.Ext2.x, which is defined in the JAR file.src/Ext1.scala.src/Depender.scala,src/Depender2.scala, andsrc/Good.scala. This should detect thattest.pkg.Ext1is now shadowed bysub2/target, and thussrc/Depender.scalamust be invalidated.problem
ff75cd1 demonstrates that current implementation does not detect this shadowing.