New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused 'resident' option #345

Merged
merged 1 commit into from Jul 8, 2017

Conversation

Projects
None yet
5 participants
@lukeindykiewicz
Contributor

lukeindykiewicz commented Jul 7, 2017

Remove unused 'resident' option, fixes #340

@lightbend-cla-validator

This comment has been minimized.

Show comment
Hide comment
@lightbend-cla-validator

lightbend-cla-validator Jul 7, 2017

Hi @lukeindykiewicz,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

lightbend-cla-validator commented Jul 7, 2017

Hi @lukeindykiewicz,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jul 7, 2017

Member

@lukeindykiewicz Thanks for the contribution, having a look at it now, we'll see what the CI reports 😄.

Member

jvican commented Jul 7, 2017

@lukeindykiewicz Thanks for the contribution, having a look at it now, we'll see what the CI reports 😄.

@lukeindykiewicz

This comment has been minimized.

Show comment
Hide comment
@lukeindykiewicz

lukeindykiewicz Jul 7, 2017

Contributor

CLA signed

Contributor

lukeindykiewicz commented Jul 7, 2017

CLA signed

@jvican jvican requested a review from Duhemm Jul 7, 2017

@Duhemm

LGTM, and welcome to Zinc @lukeindykiewicz!

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jul 7, 2017

Member

It seems this requires a manual rebase, I'll do it as soon as I can.

Member

jvican commented Jul 7, 2017

It seems this requires a manual rebase, I'll do it as soon as I can.

@jvican jvican added the spree label Jul 7, 2017

@eed3si9n eed3si9n self-requested a review Jul 7, 2017

@jvican jvican dismissed stale reviews from eed3si9n and Duhemm via 7ded74a Jul 8, 2017

@sbt sbt deleted a comment from typesafe-tools Jul 8, 2017

@jvican

jvican approved these changes Jul 8, 2017

I just rebased manually, LGTM.

@jvican jvican requested review from eed3si9n and Duhemm Jul 8, 2017

@Duhemm

Duhemm approved these changes Jul 8, 2017

LGTM!

@jvican jvican removed the request for review from eed3si9n Jul 8, 2017

@jvican

This comment has been minimized.

Show comment
Hide comment
@jvican

jvican Jul 8, 2017

Member

Merging, things haven't changed here, it was a clean rebase. /cc @eed3si9n

Member

jvican commented Jul 8, 2017

Merging, things haven't changed here, it was a clean rebase. /cc @eed3si9n

@jvican jvican merged commit 26f11d2 into sbt:1.0 Jul 8, 2017

1 check passed

continuous-integration/drone/pr the build was successful
Details

cunei pushed a commit to cunei/zinc that referenced this pull request Oct 25, 2017

Merge pull request sbt#345 from cquiroz/scala.js-0.6.18-1.0.0-M1
Added support to build on scala.js 1.0.0-M1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment