Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
ApiDiff implementation not relying on diffutils. #346
This solves #285.
I have copied the Dotty implementation directly and put it as
LGTM, and thank you again! This is a really useful contribution (/cc @smarter that may be interested in the fix).
I'm really excited about this change, it does really improve the way people will figure out what changes triggered Zinc compiles.
Thanks again @Krever!
The changes LGTM, I would just like to get confirmation from someone who's more knowledgeable than me about licensing to confirm that this PR is okay as it is.
My understanding is that we should put the actual copyright notice from dotty before the code that we borrowed?
So I'm requesting changes until someone can confirm that it's okay...
I think crediting is enough. The compiler reporter we have is also copy pasted from Scalac, and has the same license as Dotty.
I think this is completely safe to merge because Zinc used the Scala license (BSD 3-way license). That's why we don't have to add a new license to the repo.
Just a really minor comment. Thanks for the follow up on the PR!