New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve jar order in ScalaInstance.otherJars #411

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@dwijnand
Member

dwijnand commented Sep 22, 2017

No description provided.

dwijnand and others added some commits Sep 22, 2017

Add explicit type annotation
So that if `allJars` ever changes the type, `otherJars` is not affected.
@jvican

jvican approved these changes Sep 22, 2017

LGTM @dwijnand. I've added a commit adding an explicit type annotation for otherJars, so that its type doesn't change if allJars ever changes the type.

Merge if you feel comfortable with this new addition.

@dwijnand dwijnand merged commit 32e106d into sbt:1.x Sep 22, 2017

1 check passed

continuous-integration/drone/pr the build was successful
Details

@dwijnand dwijnand deleted the dwijnand:preserve-jar-order branch Sep 22, 2017

@dwijnand

This comment has been minimized.

Show comment
Hide comment
@dwijnand

dwijnand Sep 22, 2017

Member

Good addition.

Member

dwijnand commented Sep 22, 2017

Good addition.

eed3si9n added a commit to eed3si9n/zinc that referenced this pull request Sep 24, 2017

ScalaInstance refactoring
This is a refactoring change that removes two private `apply` methods. No observable changes are expected.

1. It's only used by one `apply`, so they don't provide much values.
2. One of the parameter is named incorrectly as "extraJars" when it in fact expects "allJars."

Ref sbt#5, sbt#411, sbt/sbt#3561

@eed3si9n eed3si9n referenced this pull request Sep 24, 2017

Merged

ScalaInstance refactoring #412

eed3si9n added a commit to eed3si9n/zinc that referenced this pull request Sep 24, 2017

ScalaInstance refactoring
This is a refactoring change that removes two private `apply` methods. No observable changes are expected.

1. It's only used by one `apply`, so they don't provide much values.
2. One of the parameter is named incorrectly as "extraJars" when it in fact expects "allJars."

Ref sbt#5, sbt#411, sbt/sbt#3561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment