New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Names from nonexisiting objects #422

Merged
merged 3 commits into from Jun 5, 2018

Conversation

Projects
None yet
4 participants
@romanowski
Contributor

romanowski commented Oct 7, 2017

In some cases zinc reports dependencies to non-exiting objects that are taken from e.g. imports. This may later on manifest as dependencies to jar/classes from projects that should be handled as external dependencies.

romanowski added some commits Oct 5, 2017

Create test case with files that depends on non-existing objects.
It causes to depends on jar from depended project even if it should be handled as external dependency.
import sbt.io.IO
class BinaryDepSpec extends BaseCompilerSpec{
it should "not depend on non-existing objects" in {

This comment has been minimized.

@eed3si9n

eed3si9n Oct 7, 2017

Member

Is this expectation true? What if you changed the macro? Shouldn't we invalidate the macro consumer?

This comment has been minimized.

@romanowski

romanowski Oct 10, 2017

Contributor

We do not change macro here we compile each project once.

We depend on NoopMacro but as a external dependency and we should not depended at the same time on it as library dependency (so we don't want recompile every usage of NoopMacro when we change anything in jar where it comes from)

@jvican jvican self-assigned this Oct 9, 2017

@romanowski

This comment has been minimized.

Contributor

romanowski commented Oct 10, 2017

@eed3si9n @jvican @dwijnand Please let me know if you need any need anything more to review this PR :)

@jvican

This comment has been minimized.

Member

jvican commented Oct 11, 2017

Myself I just need time. I'll get back to this once the big PRs in the queue are merged.

@dwijnand

This comment has been minimized.

Member

dwijnand commented Jun 5, 2018

Where do we stand on this PR, @romanowski @eed3si9n @jvican?

It's green and merges cleanly. Can we land it?

@dwijnand dwijnand requested review from eed3si9n and jvican Jun 5, 2018

@jvican

This comment has been minimized.

Member

jvican commented Jun 5, 2018

I’m trying to review it this week.

@jvican

jvican approved these changes Jun 5, 2018

LGTM

@jvican

This comment has been minimized.

Member

jvican commented Jun 5, 2018

I'll merge when CI passes.

@jvican jvican merged commit ec23cbc into sbt:1.x Jun 5, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@dwijnand dwijnand added this to the 1.2.0 milestone Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment