New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide separate PrintWriters for errors and warnings #506

Merged
merged 1 commit into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@kaygorodov
Contributor

kaygorodov commented Mar 5, 2018

I generate javadoc using the sbt-unidoc plugin. When using sbt 1.x, it is impossible to distinguish between errors and warnings in the console. All messages are printed out with the "error" level.

After investigation, it turned out that the problem is that the same print writer (Level.Error) is used for both errors and writers in LocalJava.scala..

I suggest to use two separate writers, and log warning and error messages with Level.Warn and Level.Error respectively.

@jvican

jvican approved these changes Mar 5, 2018

LGTM. Makes total sense. Thanks for submitting this PR, it's much appreciated.

@typesafe-tools

This comment has been minimized.

typesafe-tools commented Mar 6, 2018

The validator has checked the following projects against Scala 2.11,
tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt 1.x
zinc pull/506/head b52b409
io 1.x sbt/io@438474e
librarymanagement 1.x sbt/librarymanagement@0d21ae6
util 1.x sbt/util@85a30fa
website 1.x

The result is: SUCCESS
(restart)

@dwijnand

lgtm! thank you @kaygorodov.

@dwijnand dwijnand merged commit dc6839d into sbt:1.x Mar 6, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment