New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extract class dependency from 'classOf' Literal #510

Merged
merged 2 commits into from Mar 13, 2018

Conversation

Projects
None yet
4 participants
@natansil
Contributor

natansil commented Mar 8, 2018

fixes issue #508

@lightbend-cla-validator

This comment has been minimized.

lightbend-cla-validator commented Mar 8, 2018

Hi @natansil,

Thank you for your contribution! We really value the time you've taken to put this together.

Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement:

http://www.lightbend.com/contribute/cla

@natansil

This comment has been minimized.

Contributor

natansil commented Mar 8, 2018

@jvican as requested

@natansil

This comment has been minimized.

Contributor

natansil commented Mar 8, 2018

I've signed the CLA

@jvican

This comment has been minimized.

Member

jvican commented Mar 8, 2018

@dwijnand @eed3si9n CLA checking seems not to be working in sbt-whitesource.

@jvican

LGTM, thanks for the PR 😄 Just one comment.

@@ -112,6 +112,25 @@ class DependencySpecification extends UnitSpec {
assert(inheritance("B") === Set.empty)
}
it should "extract class dependency from 'classOf' literal" in {

This comment has been minimized.

@jvican

jvican Mar 8, 2018

Member

Could you also add a scripted (integration) test?

This comment has been minimized.

@natansil

natansil Mar 8, 2018

Contributor

Do you mean adding a test a long side this one?

This comment has been minimized.

@jvican

jvican Mar 9, 2018

Member

I mean adding a test like that one but that would fail compilation if it this fix wasn’t present, and that would succeed after the patch.

This comment has been minimized.

@natansil

natansil Mar 11, 2018

Contributor

done

@dwijnand

This comment has been minimized.

Member

dwijnand commented Mar 9, 2018

ci is failing because of a typo in #496. fixed in #511

@jvican

jvican approved these changes Mar 11, 2018

@dwijnand dwijnand added this to the 1.2.0 milestone Mar 13, 2018

@dwijnand dwijnand merged commit d6dec01 into sbt:1.x Mar 13, 2018

1 check passed

continuous-integration/drone/pr the build was successful
Details
@dwijnand

This comment has been minimized.

Member

dwijnand commented Mar 13, 2018

thank you @natansil!

@natansil

This comment has been minimized.

Contributor

natansil commented Mar 13, 2018

@dwijnand Happy to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment