extract class dependency from 'classOf' Literal #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @natansil, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
@jvican as requested |
|
I've signed the CLA |
jvican
reviewed
Mar 8, 2018
| @@ -112,6 +112,25 @@ class DependencySpecification extends UnitSpec { | |||
| assert(inheritance("B") === Set.empty) | |||
| } | |||
|
|
|||
| it should "extract class dependency from 'classOf' literal" in { | |||
There was a problem hiding this comment.
Could you also add a scripted (integration) test?
There was a problem hiding this comment.
Do you mean adding a test a long side this one?
There was a problem hiding this comment.
I mean adding a test like that one but that would fail compilation if it this fix wasn’t present, and that would succeed after the patch.
natansil
force-pushed
the
classOfLiteral
branch
from
2972674
to
ccd17b6
Compare
jvican
approved these changes
Mar 11, 2018
dwijnand
approved these changes
Mar 13, 2018
|
thank you @natansil! |
|
@dwijnand Happy to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #508