Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw when javadoc generation fails #625

Merged
merged 2 commits into from Jan 10, 2019

Conversation

@raboof
Copy link
Contributor

commented Dec 14, 2018

As discussed in #414. Unfortunately I haven't been able to run the tests,
as 'sbt clean publishBridges' already fails for me.

@typesafe-tools

This comment has been minimized.

Copy link

commented Dec 14, 2018

A validation involving this pull request is in progress...

@typesafe-tools

This comment has been minimized.

Copy link

commented Dec 14, 2018

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@17b2737
zinc pull/625/head 7420f91
io develop sbt/io@ca872a2
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

The result is: FAILED
(restart)

@raboof

This comment has been minimized.

Copy link
Contributor Author

commented Dec 14, 2018

This looks like it may be a flakey test:

[sbt212-librarymanagement] NORMAL RESOLUTION TIME 1798
[sbt212-librarymanagement] FASTER RESOLUTION TIME 1490
[sbt212-librarymanagement] [info] ModuleResolversTest:
[sbt212-librarymanagement] [info] The direct resolvers in update options
[sbt212-librarymanagement] [info] - should skip the rest of resolvers *** FAILED ***
[sbt212-librarymanagement] [info]   1490 was not less than or equal to 1438.4 (ModuleResolversTest.scala:48)
@typesafe-tools

This comment has been minimized.

Copy link

commented Dec 14, 2018

A validation involving this pull request is in progress...

@typesafe-tools

This comment has been minimized.

Copy link

commented Dec 14, 2018

The validator has checked the following projects, tested using dbuild, projects built on top of each other.

Project Reference Commit
sbt develop sbt/sbt@17b2737
zinc pull/625/head 7420f91
io develop sbt/io@ca872a2
librarymanagement develop sbt/librarymanagement@9107125
util develop sbt/util@2e0d2d9

The result is: SUCCESS
(restart)

@eed3si9n

This comment has been minimized.

Copy link
Member

commented Dec 14, 2018

Thanks @raboof!

Note: There's some test here. Maybe we can add a test for you if you can't - https://github.com/sbt/zinc/blob/develop/zinc-compile/src/test/scala/inc/DocSpec.scala

@raboof

This comment has been minimized.

Copy link
Contributor Author

commented Dec 16, 2018

Thanks for the help on Gitter, I got the tests to work an added one that checks the javadoc tool indeed throws on an invalid Java input file, rather than failing silently without output.

@eed3si9n eed3si9n requested a review from jvican Dec 16, 2018
@eed3si9n eed3si9n added the review label Jan 9, 2019
@jvican
jvican approved these changes Jan 10, 2019
Copy link
Member

left a comment

LGTM @raboof, thanks 😄

@jvican jvican merged commit f8d1bad into sbt:develop Jan 10, 2019
1 check passed
1 check passed
continuous-integration/drone/pr the build was successful
Details
@raboof raboof deleted the raboof:throwOnJavadocFailure branch Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.