Push lookupAnalyzedClass into Lookup #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... allowing users to optimize it - in both directions: in finding the class or in not finding the class (i.e. without having to lookupAnalysis).
eed3si9n
approved these changes
May 18, 2020
retronym
approved these changes
May 18, 2020
16 tasks
eed3si9n
reviewed
Jun 14, 2020
| @@ -55,6 +56,13 @@ class LookupImpl(compileConfiguration: CompileConfiguration, previousSetup: Opti | |||
| .flatMap(ext => ext.getExternalLookup().toOption) | |||
| .collect { case externalLookup: ExternalLookup => externalLookup } | |||
|
|
|||
| override def lookupAnalyzedClass(binaryClassName: String): Option[AnalyzedClass] = { | |||
| externalLookup match { // not flatMap so that external lookup can fast-track returning None | |||
There was a problem hiding this comment.
I'm trying to integrate this change into sbt, and I'm a bit confused. What does it mean for externalLookup.lookupAnalyzedClass(binaryClassName) to return None here?
sbt already implements externalLookup, so I would like a way to say I don't want to participate in AnalyzedClass lookup, but if I return None it would be interpreted as "I couldn't find the AnalyzedClass"?
There was a problem hiding this comment.
Yeah, the current setup has no way for externalLookup.lookupAnalyzedClass to say "I don't know, you try". You'd have to modify this if you need that.
I'm not sure why Some(APIs.emptyAnalyzedClass) wasn't used for fast-track's "I got you, here's the API for that class name".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... allowing users to optimize it - in both directions: in finding the
class or in not finding the class (i.e. without having to
lookupAnalysis).