Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple test device IDs (backwards compatible) #90

Closed
wants to merge 2 commits into from

Conversation

@ndbroadbent
Copy link
Contributor

@ndbroadbent ndbroadbent commented Feb 19, 2017

I renamed testDeviceID to testDeviceIDs and changed it to an array, so you can pass multiple test devices.

It is backwards compatible (with deprecation warnings), so you can still use testDeviceID for now.

@ndbroadbent ndbroadbent force-pushed the ndbroadbent:multiple_test_devices branch from d23cbc3 to 1019963 Feb 19, 2017
@ndbroadbent ndbroadbent force-pushed the ndbroadbent:multiple_test_devices branch from 1019963 to 89370a7 Feb 19, 2017
@eranbes
Copy link
Contributor

@eranbes eranbes commented Apr 17, 2017

Can you please update it to current state so add the multiple test device ids to rewarded videos, too? Thanks.

@ndbroadbent ndbroadbent force-pushed the ndbroadbent:multiple_test_devices branch from 89370a7 to f4e4ef9 Apr 17, 2017
@ndbroadbent
Copy link
Contributor Author

@ndbroadbent ndbroadbent commented Apr 17, 2017

Updated! I also updated the Example app to the latest RN version, because I found it too hard to get the old version running.

@ndbroadbent ndbroadbent force-pushed the ndbroadbent:multiple_test_devices branch from f4e4ef9 to fe8726f May 14, 2017
@ndbroadbent
Copy link
Contributor Author

@ndbroadbent ndbroadbent commented May 14, 2017

Rebased onto latest commit from master again

@tiendq
Copy link

@tiendq tiendq commented May 24, 2017

Please merge it, thanks.

@koenpunt
Copy link
Collaborator

@koenpunt koenpunt commented Oct 21, 2017

v2 of the library (currently in beta) has a testDevices property which accepts an array of test devices.

You can install the latest beta version using:

yarn add react-native-admob@next

Or

npm install --save react-native-admob@next
@koenpunt koenpunt closed this Oct 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants