Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw JsonFormatException when field should be an array but is an object #60

Merged
merged 1 commit into from Sep 17, 2019

Conversation

@sburba
Copy link
Owner

commented Sep 17, 2019

There was a bug that caused it to throw TypeError instead

Depending on your definition, this may be a breaking change. In the case
that you noticed this bug and caught TypeError but not
JsonFormatException, this would break your code. That seems incredibly
unlikely though, it seems far more likely that the harm of pushing this
change to a major version change is greater

There was a bug that caused it to throw TypeError instead

Depending on your definition, this may be a breaking change. In the case
that you noticed this bug and caught TypeError but not
JsonFormatException, this would break your code. That seems incredibly
unlikely though, it seems far more likely that the harm of pushing this
change to a major version change is greater
@codecov

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #60 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #60   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      104    105    +1     
=======================================
  Files             9      9           
  Lines           239    241    +2     
=======================================
+ Hits            239    241    +2
Impacted Files Coverage Δ Complexity Δ
src/Internal/ArrayAdapter.php 100% <100%> (ø) 5 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c464ef...7b36fd1. Read the comment docs.

@sburba sburba merged commit c818c9d into master Sep 17, 2019
3 checks passed
3 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0%) compared to 5c464ef
Details
@sburba sburba deleted the bugfix/incorrect-error-array-adapter branch Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.