-
Notifications
You must be signed in to change notification settings - Fork 0
Robot Size Configurable #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d0c01da6-48fd-4689-9a5c-f5f21d0fdd39.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
…d added async_get_pil_image to the handlers base class Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
… the go. solving issues on hyper_handler. Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
… fix no walls draw Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Updated robot drawing method to allow configurable radius for better flexibility.
Updated angle conversion from degrees to radians using math.pi.
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds configurable robot size with default max radius 25 and min radius 8, enhancing robot visualization customization.
- Add robot_size configuration parameter to device_info with default value 25
- Update robot drawing functions to use the configurable size parameter instead of hardcoded values
- Add status text functionality with multi-language support for vacuum status display
Reviewed Changes
Copilot reviewed 16 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SCR/valetudo_map_parser/config/shared.py | Adds robot_size parameter to shared configuration with default value 25 |
| SCR/valetudo_map_parser/reimg_draw.py | Updates robot drawing to use configurable robot_size from shared config |
| SCR/valetudo_map_parser/hypfer_handler.py | Updates robot drawing to use configurable robot_size parameter |
| tests/test_rand.py | Adds robot_size: 15 to test configuration |
| tests/test.py | Adds robot_size: 20 to test configuration |
| pyproject.toml | Version bump to 0.1.10b5 |
| Multiple other files | Adds status text functionality, translations, and updates font paths |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Sandro Cantarella <sandro@8a395bcd-e9fe-4738-ae9c-39b72f67e844.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@8a395bcd-e9fe-4738-ae9c-39b72f67e844.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.local>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
# Conflicts: # pyproject.toml
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
…rs WebP handling removed. Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@7a56e4a7-42f9-425e-9c4b-d870c799bb4a.fritz.box>
sca075
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 29 changed files in this pull request and generated 5 comments.
Comments suppressed due to low confidence (1)
tests/test_rand.py:1
- Debug print statement should be removed from production test code or replaced with proper logging using the
_LOGGERinstance already available in the test class.
from __future__ import annotations
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Sandro Cantarella <sandro@7a56e4a7-42f9-425e-9c4b-d870c799bb4a.fritz.box>
Refactor map_data.py to improve type hints and structure.
Refactor map_data.py with TypedDicts and type hints
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Users should be able to configure the robot size default is max radius 25 and min radius will be 8