Skip to content

Conversation

@sca075
Copy link
Owner

@sca075 sca075 commented Aug 27, 2025

Users should be able to configure the robot size default is max radius 25 and min radius will be 8

sca075 added 24 commits August 6, 2025 17:37
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d0c01da6-48fd-4689-9a5c-f5f21d0fdd39.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
…d added async_get_pil_image to the handlers base class

Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
… the go. solving issues on hyper_handler.

Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@d3548ddd-0920-4ec4-b22e-8d29b286c8c1.fritz.box>
… fix no walls draw

Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Updated robot drawing method to allow configurable radius for better flexibility.
@sca075 sca075 self-assigned this Aug 27, 2025
@sca075 sca075 marked this pull request as draft August 27, 2025 10:07
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
@sca075 sca075 requested a review from Copilot September 11, 2025 21:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable robot size with default max radius 25 and min radius 8, enhancing robot visualization customization.

  • Add robot_size configuration parameter to device_info with default value 25
  • Update robot drawing functions to use the configurable size parameter instead of hardcoded values
  • Add status text functionality with multi-language support for vacuum status display

Reviewed Changes

Copilot reviewed 16 out of 23 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
SCR/valetudo_map_parser/config/shared.py Adds robot_size parameter to shared configuration with default value 25
SCR/valetudo_map_parser/reimg_draw.py Updates robot drawing to use configurable robot_size from shared config
SCR/valetudo_map_parser/hypfer_handler.py Updates robot drawing to use configurable robot_size parameter
tests/test_rand.py Adds robot_size: 15 to test configuration
tests/test.py Adds robot_size: 20 to test configuration
pyproject.toml Version bump to 0.1.10b5
Multiple other files Adds status text functionality, translations, and updates font paths

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Signed-off-by: Sandro Cantarella <sandro@8a395bcd-e9fe-4738-ae9c-39b72f67e844.fritz.box>
sca075 and others added 17 commits September 12, 2025 08:50
Signed-off-by: Sandro Cantarella <sandro@8a395bcd-e9fe-4738-ae9c-39b72f67e844.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.local>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
…rs WebP handling removed.

Signed-off-by: Sandro Cantarella <sandro@Sandros-Mac-mini.fritz.box>
Signed-off-by: Sandro Cantarella <sandro@7a56e4a7-42f9-425e-9c4b-d870c799bb4a.fritz.box>
Copy link
Owner Author

@sca075 sca075 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@sca075 sca075 requested a review from Copilot September 26, 2025 06:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 22 out of 29 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

tests/test_rand.py:1

  • Debug print statement should be removed from production test code or replaced with proper logging using the _LOGGER instance already available in the test class.
from __future__ import annotations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

sca075 and others added 4 commits September 26, 2025 09:10
Signed-off-by: Sandro Cantarella <sandro@7a56e4a7-42f9-425e-9c4b-d870c799bb4a.fritz.box>
Refactor map_data.py to improve type hints and structure.
Refactor map_data.py with TypedDicts and type hints
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@sca075 sca075 merged commit cd4213c into main Sep 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants