From c4ad2f2c1739ee6f27de18e222d455e2bb363144 Mon Sep 17 00:00:00 2001 From: Kevin Joshi Date: Mon, 24 Apr 2023 14:41:01 +0530 Subject: [PATCH 1/3] fix: visibility of icons in input MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - `#` in `Bytes32Input` & `BytesInput`, `*` in IntegerInput and `$, Ξ` in `EtherInput` are now clearly visible even in dark mode and display color set to `text-gray-400` --- packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/IntegerInput.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx index f2e16b112..69d8ecdb0 100644 --- a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx @@ -22,7 +22,7 @@ export const Bytes32Input = ({ value, onChange, name, placeholder }: CommonInput onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx index 3493aeaa6..b18f1bbef 100644 --- a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx @@ -19,7 +19,7 @@ export const BytesInput = ({ value, onChange, name, placeholder }: CommonInputPr onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx index f0f8768e9..038f6c7b5 100644 --- a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx @@ -93,7 +93,7 @@ export const EtherInput = ({ value, name, placeholder, onChange }: CommonInputPr value={displayValue} placeholder={placeholder} onChange={handleChangeNumber} - prefix={{usdMode ? "$" : "Ξ"}} + prefix={{usdMode ? "$" : "Ξ"}} suffix={
From b6b490babb1b8083335d891a5ed3d68ebf839cd7 Mon Sep 17 00:00:00 2001 From: Kevin Joshi Date: Tue, 25 Apr 2023 23:05:12 +0530 Subject: [PATCH 2/3] fix: visibility of icons in IntegerInput & revert - Reverted rest of the changes and set IntegerInput icons to be text-primary --- packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/IntegerInput.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx index 69d8ecdb0..1800ba21d 100644 --- a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx @@ -22,7 +22,7 @@ export const Bytes32Input = ({ value, onChange, name, placeholder }: CommonInput onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx index b18f1bbef..a63715869 100644 --- a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx @@ -19,7 +19,7 @@ export const BytesInput = ({ value, onChange, name, placeholder }: CommonInputPr onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx index 038f6c7b5..f0f8768e9 100644 --- a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx @@ -93,7 +93,7 @@ export const EtherInput = ({ value, name, placeholder, onChange }: CommonInputPr value={displayValue} placeholder={placeholder} onChange={handleChangeNumber} - prefix={{usdMode ? "$" : "Ξ"}} + prefix={{usdMode ? "$" : "Ξ"}} suffix={
From 0e3a10f4caba34fa020757c4eca0460eb85ca179 Mon Sep 17 00:00:00 2001 From: Kevin Joshi Date: Wed, 26 Apr 2023 00:17:07 +0530 Subject: [PATCH 3/3] fix: `text-primary` -> `text-accent` --- packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx | 2 +- packages/nextjs/components/scaffold-eth/Input/IntegerInput.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx index 1800ba21d..f2e16b112 100644 --- a/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/Bytes32Input.tsx @@ -22,7 +22,7 @@ export const Bytes32Input = ({ value, onChange, name, placeholder }: CommonInput onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx index a63715869..3493aeaa6 100644 --- a/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/BytesInput.tsx @@ -19,7 +19,7 @@ export const BytesInput = ({ value, onChange, name, placeholder }: CommonInputPr onChange={onChange} suffix={
# diff --git a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx index f0f8768e9..1228c35c2 100644 --- a/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx +++ b/packages/nextjs/components/scaffold-eth/Input/EtherInput.tsx @@ -93,7 +93,7 @@ export const EtherInput = ({ value, name, placeholder, onChange }: CommonInputPr value={displayValue} placeholder={placeholder} onChange={handleChangeNumber} - prefix={{usdMode ? "$" : "Ξ"}} + prefix={{usdMode ? "$" : "Ξ"}} suffix={