Browse files

Added 'org.eclipse.jdt.groovy.core' in Eclipse-SupplementBundle secti…

…on of

MANIFEST. Fix #1000798

To correct #3135 we removed the AJDT dependency from the Scala IDE. An
undesired side-effect of this change was that the Scala IDE was no longer
usable if the Groovy IDE was also installed.
The problem was that our (aspect) class responsible of intercepting the call to
create a ScalaSourceFile was no longer used, that because our class was
targeting the 'org.eclipse.jdt.core' bundle, which is not loaded when the
Groovy IDE is installed.
The fix was to edit the MANIFEST's Eclipse-SupplementBundle section of our
'org.scala-ide.sdt.aspects' project, and make sure that our aspect class is
called also when the call is performed from the 'org.eclipse.jdt.groovy.core'
bundle (which is the Groovy IDE core bundle). The AJDT plugin does exactly
that, and that is why this problem was a side-effect of removing the AJDT
dependency from the Scala IDE.

(no review)
  • Loading branch information...
1 parent 06d2a99 commit 3b477dd3c3a9ecab9e47343534be0b471a9cbcd4 Mirco Dotta committed Dec 12, 2011
Showing with 2 additions and 1 deletion.
  1. +2 −1 org.scala-ide.sdt.aspects/META-INF/MANIFEST.MF
3 org.scala-ide.sdt.aspects/META-INF/MANIFEST.MF
@@ -30,7 +30,8 @@ Eclipse-SupplementBundle:
- org.eclipse.pde.ui
+ org.eclipse.pde.ui,
+ org.eclipse.jdt.groovy.core
Bundle-ActivationPolicy: lazy

0 comments on commit 3b477dd

Please sign in to comment.