Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 28, 2011
  1. Mirco Dotta

    Removed scalanature from the .classpath of sbt.full.library project (…

    dotta authored
    …otherwise the classpath validator will complain the the scala library is missing, therefore it is working as expected :)
  2. Mirco Dotta

    Revert "Fixes #1000406. Also don't add compiler to the classpath auto…

    dotta authored
    …matically"
    
    This reverts commit 18a034b.
  3. Mirco Dotta

    Check if the position is defined or an exception is produced and that…

    dotta authored
    … will cause the ContentAssistError dialog to pop up. I also changed usages of 'pos.start' into 'pos.startOrPoint' as it is safer.
    
    This fix only prevents the error dialog to show up, nd it does not fix ticket Re #1000705 (completion is still not working as expected).
  4. Luc Bourlier

    Merge pull request #24 from scala-ide/issue/classpath-validator-2-100…

    skyluc authored
    …0631
    
    Stop resetting compilers when the classpath is invalid
  5. Luc Bourlier

    Re #1000631. Modified so the compilers are not reset when the classpa…

    skyluc authored
    …th is invalid.
    
    The reset in this case is useless, generates log and was making the tests fail on trully
    headless systems.
  6. Iulian Dragos

    Merge pull request #23 from scala-ide/issue/reset-uninitialized-pc-10…

    dragos authored
    …00704
    
    Make 'resetPresentationCompiler' do nothing on reset, if the presentation compiler is not yet initialized.
  7. Iulian Dragos

    Made elem @volatile, so that 'initialized' to guarantee

    dragos authored
    visibility form other threads that call 'initialized'.
  8. Hubert Plociniczak
  9. Mirko Stocker

    Make sure the AST is up to date before adding an import.

    misto authored
    It looks like my fix for #1000668 was not enough; the refactoring library
    gets confused quickly if it doesn't have a completely typechecked AST.
    
    This also fixes #1000599.
    (cherry picked from commit 2296fd8)
  10. Iulian Dragos

    Make 'resetPresentationCompiler' do nothing on reset, if the presenta…

    dragos authored
    …tion compiler
    
    was not yet initialized. This avoids waking up the compiler just to tell it to shutdown,
    and also eliminates a source of deadlocks or recursive initializations (for instance, if
    reset is called while initializing the presentation compiler). Fixed #1000704.
  11. Iulian Dragos

    Merge pull request #21 from scala-ide/feature/find-references-1000698

    dragos authored
    Feature/find references 1000698
  12. Iulian Dragos

    Fixed typo in comment.

    dragos authored
  13. Iulian Dragos
Commits on Oct 27, 2011
  1. Hubert Plociniczak
  2. Luc Bourlier
  3. Iulian Dragos
  4. Iulian Dragos
  5. Iulian Dragos

    Removed unused import.

    dragos authored
  6. Iulian Dragos

    Don't pollute the Error Log with unimplemented behavior, use the logg…

    dragos authored
    …er instead. Fixed #1000357.
  7. Iulian Dragos

    Initial commit for Find references. Fixed already existing code. Basi…

    dragos authored
    …c search works,
    
    but only through the Java Search window (no right-click support). Method definitions and references are not distinguished, probably still some bugs that need ironing out. In the medium term we need to revamp ScalaMatchLocator.
    
    Refs #1000698.
  8. Mirco Dotta
  9. Mirco Dotta

    Revert "Fixed compilation of the IDE against compiler 2.8. Problem wa…

    dotta authored
    …s that usage of 'Manifest.singleType', which is available only for 2.9+. To fix compilation I duplicated in our codebase the implementation of 'Manifest.singleType` and added a deprecation note for removing the change once we abandon 2.8 support (maybe we would be better of with a custom assertion...). This change is related to ticket Re #1000691. Commit should be reviewed by @mdr."
    
    This reverts commit 2d82c80.
  10. Mirco Dotta

    Updated code accordingly to review in pull request #18. Added quite a…

    dotta authored
    … few more test for checking that Java code can correctly reference trait's types.
  11. Mirco Dotta

    Updated ScalaStructureBuilder, as it is responsible of correctly expo…

    dotta authored
    …sing module's inner classes to JDT. The issue was that module's inner classes were exposed as member of the $ module class, which is wrong, since the scala compiler expose them as inner classes of the module's companion class.
    
    I moved the code that was responsible of traversing the Scala AST Tree into a new class 'TreeTraverser', that takes a new field 'module2innerClassDefs' used to keep track of inner classes that are defined in a module. This solution has the advantage of avoiding possible memory leaks that could result from not correctly cleaning the 'module2innerClassDefs' map.
    
    Fixed ticket Re #1000678.
  12. Mirco Dotta

    Commented on why test for ticket Re #1000692 is currently disabled de…

    dotta authored
    …spite Martin seem to have fixed it in the Presentation Compiler. I think we should NOT close the ticket until we know why the test is failing (we'll take a look at it after 2.0 release).
  13. Mirko Stocker

    Always wrap refactoring actions in a compiler.ask call.

    misto authored
    I must have missed this when I went through all the refactoring code. This
    seems to fix #1000668, where the refactoring generated invalid code.
    (cherry picked from commit 81ae1c4)
Commits on Oct 26, 2011
  1. Mirco Dotta

    Fixed compilation of the IDE against compiler 2.8. Problem was that u…

    dotta authored
    …sage of 'Manifest.singleType', which is available only for 2.9+. To fix compilation I duplicated in our codebase the implementation of 'Manifest.singleType` and added a deprecation note for removing the change once we abandon 2.8 support (maybe we would be better of with a custom assertion...). This change is related to ticket Re #1000691. Commit should be reviewed by @mdr.
Commits on Oct 25, 2011
  1. Matt Russell
  2. Matt Russell
Commits on Oct 24, 2011
  1. Mirco Dotta
  2. Mirco Dotta

    Created test for ticket Re #1000692, which is currently disabled beca…

    dotta authored
    …use the issue needs to be fixed in the presentation compiler (I tried to reproduce the problem with a presentation compiler test, but so far I did not succeeded in isolating the issue outside the IDE. Though, I'm sure that the issue described in this ticket has to be fixed in the presentation compiler.).
    
    While creating the test I had to refactor a bit class 'HyperlinkDetectorTester'. Specifically, I needed to extract the functionality used to test hyperlinking in a scala file, as the issue described in this ticket becomes apparent only *after* a hyperlink request is issued on a specific class' symbol.
    
    Last, I also changed CustomAssertion to have a self type 'TestProjectSetup', as in this way the current 'project' does no longer need to be passed to 'assertNoErrors'.
  3. Hubert Plociniczak
  4. Luc Bourlier

    Merge pull request #10 from scala-ide/issue/classpath-validator-1000631

    skyluc authored
    Issue/classpath validator 1000631
  5. Luc Bourlier
  6. Hubert Plociniczak

    Merge branch 'feature/allow-sbt-to-change-the-order-of-compilation-10…

    hubertp authored
    …00664' into release/scala-ide-2.0.x
Something went wrong with that request. Please try again.