Permalink
Commits on Nov 9, 2011
  1. Cherrypicked fix for #1000406.

    Reverting the revert (that's sounds weird btw): "Revert "Fixes #1000406. Also don't add compiler to the classpath automatically"" and fixed the underlying problem. Also added a bunch of tests for sbt builder for other bugs. Not sure how to force jdk change easily for this bug, so I am leaving the test case open
    
    Cherry-picked from d98125e without ImplicitsHighlighting test.
    
    Added files necessary to initialize workspace for the tests
    (cherry picked from commit a9a3f72)
    
    Finally fixed tests, which revealed problem with the build manager in testSimpleJavaDep test in ScalaJavaDepTest. We seem to still remove java classes and sbt assumes that they are still there.
    (cherry picked from commit 31bb845)
    
    Ignore failing test for now (it is not related to this ticket anyway, but to builder in general. Made smaller jar for compiler testing
    (cherry picked from commit 0c9bb34)
    
    Typo
    (cherry picked from commit 0e60fea)
    
    I was overzealous with my changes. Incorported fix pointed out in the review
    (cherry picked from commit 77472e6)
    hubertp committed Oct 31, 2011
Commits on Nov 8, 2011
  1. The ScalaMethodVerifierProvider needs to access the active project to…

    … query the presentation compiler and retrieve the
    
    symbol associated to a MethodBinding.
    
    To retrieve the active project we need to use the Eclipse Workbench, which is a UI component. Consequently, I had to
    ignore all tests related to the ScalaMethodVerifierProvider, as they would fail in headless mode.
    
    The strategy we used in the past to retrieve the project was simply broken. In fact, it was crashing when the MethodBinding
    was coming from a binary classfile (check Re #1000660 for a practical example).
    
    I'll work on re-enabling them but I'd like to push this forward as it Fixes #1000660, #1000715.
    
    Iulian is right, if the MethodBinding is coming from a binary file, then we don't need to run it through the
    ScalaMethodVerifierProvider, because all the mixed-in methods have been added (therefore Java compilers sees
    the correct types).
    dotta committed Nov 8, 2011
  2. Updated About.

    dotta committed Nov 8, 2011
  3. Decoupled the Scala library version from the Scala compiler version w…

    …hen building the toolchain.
    
    Build the toolchain by using the stable 2.9.1 scala library, and the 2.9.2-SNAPSHOT
    compiler.
    
    Cleaned up build profiles and removed obsolete scripts.(cherry picked from commit 8c8419f)
    Iulian Dragos committed with dragos Nov 6, 2011
Commits on Nov 7, 2011
  1. Merge branch 'issue/classpath-validator-vs-sbt-vs-m2eclipse-1000728' …

    …into release/scala-ide-2.0.x
    skyluc committed Nov 7, 2011
  2. Added test for #1000634

    hubertp committed Nov 7, 2011
  3. Closes #1000634. Minor changes in sbt were already done and published…

    …. Basically the comment information needed to be propagated further to the original eclipse build reporter (that by default handles comments correctly) rather than be ignored inside sbt
    hubertp committed Nov 7, 2011
  4. Fixed #1000480. Added a project chooser.

    If the view is opened without a scala project, a UI allowing to select a project is displayed.
    After selection of a project by the user, the view with the correct interpreter is opened.
    The list of projects is updated as projects are opened, closed, created or deleted.
    skyluc committed Nov 1, 2011
  5. Fixed #1000728. Modified classpath validator to accept multiple scala…

    … library jars of compatible version.
    
    Extended tests for the new cases.
    skyluc committed Nov 7, 2011
  6. Incorporated reviewer comments.

    dragos committed Nov 7, 2011
  7. Copy resources to the output directory. This runs the JDT Java builde…

    …r for this purpose, even when there are no modified Java files.
    
    Fixed #1000636.
    dragos committed Nov 7, 2011
  8. Some merge or pull request accidentally pulled this commit, making th…

    …e 2.0.x branch have the
    
    2.1 version.
    
    Revert "Bumped the version number for master, who becomes the official 2.1.x branch! Champagne!"
    
    This reverts commit 4d4f25e.
    dragos committed Nov 7, 2011
  9. Added test for checking the Outline is correctly built (i.e., types d…

    …eclared inside a module are correctly shown in the Outline). Fixes #1000711.
    dotta committed Nov 7, 2011
Commits on Nov 6, 2011
  1. To be visible from Java sources, classes nested in a module have to b…

    …e exposed as children
    
    of the module's companion class (this matches the Scala compiler's behavior). To this end,
    when traversing a ClassDef tree node, we were checking its symbol's owner to know if the
    declaration was nested in a module. This manipulation was from time to time preventing the
    structure builder to correctly traverse the file (and produced an exception:
    'java.lang.Error: no-symbol does not have owner').
    
    The issue is that symbols in the structure builder have to be handled with care, as we deal
    with trees that are not fully typechecked, and consequently most symbols are not set.
    
    Therefore, I reworked the way we check if a ClassDef is nested in a module, and no symbol is
    used this time to carry out the check.
    
    Furthermore, I noticed a slight regression, i.e., ClassDefs nested in a module where no longer
    shown as children of the module in the Eclipse Outline (this because they were traversed as
    children of the module's companion class, which may not exist in the editor, and hence it would
    not be shown in the Outline).
    The underneath problem is that the Outline is currently too coupled to the structure builder,
    and therefore no real solution exist to correctly build the Outline view (without a major rewriting,
    which it can't happen now).
    The current solution is to show ClassDefs nested in a module twice if both the module and the
    companion class exist. This is not ideal, but in this way ClassDefs nested in a module will
    be reported in the Outline view.
    dotta committed Nov 6, 2011
Commits on Nov 4, 2011
  1. Merge branch 'issue/spurious-errors-clean-build-1000699'

    Iulian Dragos committed Nov 4, 2011
  2. Integrated reviews.

    dragos committed with Iulian Dragos Nov 1, 2011
  3. Reworked the way the presentation compiler is restarted when projects…

    … change.
    
    - A project resets the presentation compiler of all projects that depend on it after a successful build.
    - A project resets its own presentation compiler when one of the projects it depends on has changes (such as a class path change)
    - A class path change, or an added source file, restarts the PC
    
    Fixed #1000699. Test #1000645.
    dragos committed with Iulian Dragos Oct 31, 2011
  4. Fixed wrong assertion in type mapper for scala.Array. The Array objec…

    …t does not take
    
    type parameters.
    dragos committed with Iulian Dragos Oct 30, 2011
Commits on Nov 3, 2011
  1. Fixed #1000717. added focus to rename textfield

    (cherry picked from commit 1bc5468)
    stillalex committed with misto Nov 3, 2011
  2. Merge pull request #30 from alexparvulescu/master

    #1000717 fix by setting the focus to the textfield.
    misto committed Nov 3, 2011
  3. Quick fix to prevent the Scala IDE plugin to make Eclipse unstable be…

    …cause of a OS sensitive manipulation of (file system) paths. I need to spend more time and nail this down, but this commit should prevent breakages. Look at Re #1000660 and Re #10007175, no review.
    dotta committed Nov 3, 2011
Commits on Nov 1, 2011
  1. Re #1000412. Updated test code as adviced in the review.

    Improved the comment about test case reference.
    skyluc committed Nov 1, 2011
  2. Merge pull request #26 from scala-ide/issue/auto-indenter-get-confuse…

    …d-1000688
    
    Created a new indenter strategy that will automatically add a closing bracket
    dotta committed Nov 1, 2011
  3. Merge pull request #29 from scala-ide/issue/classpath-validator-3-100…

    …0631
    
    Error with classpath validator #1000631
    skyluc committed Nov 1, 2011
  4. Fixed #1000631. It is somehow link to inter-project dependency.

    Added check so markers are modified in the project is closed.
    skyluc committed Nov 1, 2011
Commits on Oct 31, 2011
  1. Created a new indenter strategy that will automatically add a closing…

    … bracket every time the user enters a left bracket (the caret's position is set in-between brackets).
    
    This strategy is only applied if the text partitioning that is being indented is either a 'IJavaPartitions.JAVA_CHARACTER' or a 'IDocument.DEFAULT_CONTENT_TYPE' (this because we want things like IJavaPartitions.JAVA_DOC or IJavaPartitions.JAVA_MULTI_LINE_COMMENT not to be affected by this strategy. Check class 'ScalaSourceViewerConfiguration' for more details).
    Fixed #1000688.
    dotta committed Oct 31, 2011