Skip to content
Commits on Jul 4, 2012
  1. @dotta

    Truncate too long build error messages displayed in resources' marker

    dotta committed
    Markers are a general mechanism for associating notes and meta-data with
    resources.  The Eclipse environments dictates that the text message passed to a
    marker should not be bigger than 21000 chars, or an assertion failure saying
    
    > Marker property value is too long
    
    is thrown on the user's face.
    
    The actual logic for resizing the build error problem passed to a marker
    already existed in two places. While the message passed to the created marker
    was correctly truncated in ``FileUtils.buildError``, it was not in
    ``ScalaProject.buildErrors``.
    
    As part of this commit, I've centralized the creation of resource markers in
    ``MarkerFactory``, and build problem markers are now created using
    ``BuildProblemMarker`` (it's a subclass of ``MarkerFactory```).
    
    More cleaning up could be done so that all markers are created only through
    sublcasses of `MarkerFactory``. Though, such a big refactoring seem too risky
    at the moment, as this commit will be merged in ``release/2.0.x`` branch.
    
    Fix #1001107
    (cherry picked from commit be013c2)
    
    Conflicts:
    
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/BuildReporter.scala
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/refined/EclipseRefinedBuildManager.scala
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/sbtintegration/EclipseSbtBuildManager.scala
Commits on Jul 3, 2012
  1. @dotta

    Fixed NPE occurring when creating a Scala Application using the wizard

    dotta committed
    This could occur if no Scala project was selected, e.g., by clicking on a
    closed project (or outside of the Package Explorer) and File > New > Scala
    Application, the reported NPE would have occurred.
    
    Fix #1000797, #1001115
    (cherry picked from commit b82bffe)
Commits on Jun 28, 2012
  1. @dotta

    Warn the user if JDT Weaving is OFF

    dotta committed
    At startup, check that JDT Weaving is enabled. If it's not, then
    warn the user through a dialog box and programmatically
    enable JDT Weaving (and restart the workbench) upon confirmation.
    
    Note that there is no way for the user to silent the dialog. Each time the
    Scala IDE plugin is activated the check will be performed, and if JDT
    Weaving is OFF the above mentioned message will be displayed. If the
    user doesn't want to see the dialog, it will have three options:
    
    * Enable JDT Weaving
    * Disable the Scala IDE core bundle (using the OSGi console)
    * Uninstall the Scala IDE plugin
    
    Fix #1001104
    (cherry picked from commit 64aa951)
Commits on Jun 27, 2012
  1. @dotta
Commits on Jun 26, 2012
  1. @dotta

    Corrected ``MainClassVerifier`` (Re #1001096)

    dotta committed
    The logic in ``MainClassVerifier`` was partially broken. Indeed, the logic used
    for checking that the main unit's package declaration matched its physical
    location (rule 3. in the comment) was:
    
      1) plain wrong, and
      2) not neeeded because rule 2. was already taking care of it.
    
    Therefore, all code related to rule 3. was removed, and the test provided with #1001096
    has been added to the regression suite.
    
    Re #1000541
    
    Fix #1001096
    (cherry picked from commit 9f4920a)
Commits on Jun 21, 2012
  1. @skyluc

    Changed the 'kind' of the Scala library container

    skyluc committed
    See re #1000919 for explanation about container kind.
    
    Fix #1000798
    Fix #1000919
    Fix #1001022
    (manually merged from 1e308b4)
Commits on Jun 18, 2012
  1. @dragos

    Better matching between file-system paths and workspace resources.

    dragos committed
    A file-system path may correspond to several resources in the workspace. We used to choose
    the first one, which lead to build errors being attached to the top-level project in nested
    project setups, even when the error belonged to a nested project.
    
    Fixes #1000734, #1000621, #1000881. Should be back ported to 2.0.x
    (cherry picked from commit ca87df4)
    
    Conflicts:
    
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/BuildReporter.scala
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/buildmanager/sbtintegration/SbtBuildReporter.scala
  2. @dragos

    Fixed NPE when hovering over the 'Run As' button, for instance from P…

    dragos committed
    …lay templates.
    
    (cherry picked from commit 7b530c4)
  3. @dotta

    Made ``Run As Scala Application`` more robust

    dotta committed
    Display a dialog when trying to run a scala application if:
    
    * The project cannot be built (if that is the case, no binary is produced, hence the application cannot be run).
    * The package name doesn't match the source's physical location (this is a known limitation Re #1000541)
    * The main type name provided in the Launch Configuration does not point to an existing source.
    
    Fixed #1000911
    (cherry picked from commit 0b5f458)
    
    Conflicts:
    
    	org.scala-ide.sdt.core.tests/src/scala/tools/eclipse/TestsSuite.java
  4. @skyluc

    Merge pull request #123 from skyluc/issue/available-tests-bundle-1001080

    skyluc committed
    Make sdt.core.test reusable on 2.0.x
Commits on Jun 15, 2012
  1. @skyluc

    Make sdt.core.test reusable

    skyluc committed
    Modified so the test platform can be used by other test fragments.
    Added to the update site in a dev support feature.
    
    This is a partial merge of:
    8110963 (test platform update)
    bfc88fd (new feature)
    
    Fix #1001080
  2. @skyluc

    Clean file handle on refreshing changed files

    skyluc committed
    The custom code I wrote to read an IFile was not releasing the file handle correctly.
    It was eventually closed when the object was GCed.
    Replaced the code with some internal jdt util method.
    Removed the incorrect method.
    
    Fix #1000909
    
    This is a manual merge of bfb6d58 and part of be46489 from master.
  3. @skyluc
Commits on May 15, 2012
  1. @dotta

    Correctly expose to JDT Scala sources' throws annotations

    dotta committed
    Scala @throws annotation were not exposed to JDT up until now, which was
    causing wrong errors to be reported by the Scala presentation compiler.
    
    Fix #1001005, #1000707 and #1000800
    (cherry picked from commit 055a81c)
Commits on May 14, 2012
  1. @dotta

    Don't show Source Generation and Externalize (String) groups in edito…

    dotta committed
    …r menu
    
    Disabled Java specific actions for Source Generation and Externalizing String.
    These actions were displayed in the editor's context menu, under the Source menu item.
    
    Created an enhancement ticket (Re #1001018).
    
    Fixed #1000972
    (cherry picked from commit 0fe0f5b)
Commits on May 11, 2012
  1. @dragos

    Use the configured JDK when instantiating the presentation compiler.

    dragos committed
    The Scala compiler adds the currently running JDK to the class path, taking precedence over the JDK
    configured in the build path. This commit fixed #1000820, and generalizes the scheme used by the Sbt
    builder.(cherry picked from commit ab2137e)
Commits on Apr 23, 2012
  1. @dotta
Commits on Mar 23, 2012
  1. @dotta

    Revert "Re-introduced version number in org.scala-ide.sbt.full.librar…

    dotta committed
    …y POM (it
    
    is suffixed in the name assigned to the bundled JAR)"
    
    This is not needed (and actually it turns out to be just completely useless).
    The reason is that when creating a p2 repository the version suffixed to the
    JAR's name is the ``<Bundle-Version>`` declared in the MANIFEST.
    
    Sorry for the noise.
    
    This reverts commit 4bad326.
  2. @dotta

    Re-introduced version number in org.scala-ide.sbt.full.library POM (i…

    dotta committed
    …t is suffixed in the name assigned to the bundled JAR)
Commits on Mar 22, 2012
  1. @dotta

    Updated the scala-toolchain-scalaide-2.0.x toolchain URL defined for …

    dotta committed
    …the 2.9.2-SNAPSHOT profile (in the pom file)
  2. @dotta
Commits on Mar 21, 2012
  1. @dotta
  2. @dotta

    Some heavy cleanup of pom files and scripts. Further, I have created …

    dotta committed
    …a parent
    
    pom project that contains properties common to all subprojects.
Commits on Mar 16, 2012
  1. @dotta
  2. @dragos @dotta
Commits on Mar 15, 2012
  1. @skyluc

    Correctly handle preferences change events

    skyluc committed
    Some Java preferences get set the first time a code template is
    used. This preference changes trigger UI updates, but the Java editor
    (base of the Scala editor) does not execute these UI updates in the right
    thread.
    Forcing those preference change to be run in the UI thread.
    Fixes #1000738
    (cherry picked from commit 8f534ee)
    
    Conflicts:
    
    	org.scala-ide.sdt.core/src/scala/tools/eclipse/ScalaSourceFileEditor.scala
Commits on Mar 6, 2012
  1. @dotta
  2. @dotta

    Build the IDE using 2.0.x p2 repo for scalariform and scala-refactoring.

    dotta committed
    The release/scala-ide-2.0.x branch need to be built using the release/scala-ide-2.0.x
    branches of both scala-refactoring and scalariform projects (look at the forked projects
    under scala-ide on github). To this end, I've made the necessary changes in the
    ``org.scala-ide.build`` POM file (look at the ``scala-2.9.2-SNAPSHOT`` profile).
    
    As part of this commit, I've also removed all profiles we don't use for building the
    Scala IDE 2.0.x. FInally, we don't need to build 2.0.x nightly for Scala 2.10 (it makes
    little sense, and it would actually require compiling scalariform and scala-refactoring
    with 2.10, create a Jenkins build, and such...).
    
    No review.
  3. @dotta

    Revert "Fixed build to adapt to new scalariform API."

    dotta committed
    This reverts commit 9b7d398.
    
    The commit was needed because we used to build the release/scala-ide-2.0.x
    branch against scalariform and scala-refactoring *master*, indeed not a wise
    thing. Now, to build the release/scala-ide-2.0.x we are going to use
    the scala-ide-2.0.0-29 tag (which was created for the 2.0.0 release).
  4. @dotta

    Open Declaration via the context menu now works as expected.

    dotta committed
    When the user right clicks on a element and select "Open Declaration" in the
    context menu, an instance of ``OpenAction`` is used to resolve the binding and
    jump to the declaration.
    
    Because the Eclipse API does not expose an extension point for this action, I
    had to create a custom extension point (using AJDT), which allows weaving in to
    JDT and can be used to intercept the creation of ``OpenAction``, if it
    originates from a Scala editor.
    
    This seem to be the only solution, which does not involve creating our own
    Scala Editor. Hopefully, we will be able to remove this custom extension point
    once we implement the Scala Editor (this is planned for Milestone 2 of the
    Scala IDE Helium).  Using AJDT for customizing the behavior of ``OpenAction``
    was also suggested by Andrew Eisenberg in the following StackOverflow question:
    
    	http://stackoverflow.com/questions/1882053/how-can-i-define-a-custom-action-for-open-declaration-shortcut-f3-in-eclipse
    
    Fix #1000920.
    (cherry picked from commit d43126d)
  5. @skyluc

    Fixed problem if typing braces at EOF.

    skyluc committed
    Added test cases.
    Re #1000926
    (cherry picked from commit 2405b62)
  6. @skyluc

    Improved closing braces managment

    skyluc committed
    - closing brace is delete when deleting an adjoining opening brace
    - closing brace is jumped (not added) when hitting the '}' key.
    Added some weak regression tests.
    (cherry picked from commit 5af52de)
Commits on Mar 5, 2012
  1. @dragos

    Removed useless distinction between `hasErrors` and `hasBuildErrors`.…

    dragos committed
    …(cherry picked from commit 24a4734)
  2. @dragos
  3. @dragos

    Added project dependencies test, and refactored some other tests to r…

    dragos committed
    …euse more code. Fixed #1000894.
    
    (cherry picked from commit 390a1cf)
Something went wrong with that request. Please try again.