Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Feb 14, 2014
  1. @dragos

    Package structure reorganisation.

    dragos authored
    This commit keeps all filenames unchanged, but builds a cleaner
    package structure of the IDE.
    There are only 5 top-level packages now:
    - core
    - ui
    - logger
    - util
    - refactoring
    Code is split in internal and API packages. Note that this commit
    only touches directories, and the API work (clean up, documentation,
    interfaces) will follow.
    The guideline was to keep related code together. The only exception is
     ui code, that is moved to its top-level package. Additional dimensions
     (for example, following Eclipse concepts like launchers or preferences
     would make it too hard to decide what goes where).
    Two unused files were removed:
    - JVMUtils
    - util/Colors.scala
    This organisation makes it easier to see duplicated functionality (like
    several RegionOps implicit classes). However, to keep things simple, that work is delayed to follow up PRs, so code changes can be independently 
    and easily reviewed.
Commits on Sep 30, 2013
  1. @dragos

    Correctly build projects that depend through exported dependencies.

    dragos authored
    The Scala builder optimised the case where the builder was triggered with
    no changes in a project, by skipping the call to the underlying Sbt builder.
    This is wrong when the project has no changes itself, but a dependent project has.
    Fixed #1001904.
    Consider for back porting to 3.0.x
Commits on Sep 12, 2013
  1. @dragos

    Reviewer's comment.

    dragos authored
  2. @dragos
  3. @dragos
  4. @dragos

    Fix source file caching in presentation compiler.

    dragos authored
    Removed the sourceFile map altogether. Caching is performed now at the
    level of `InteractiveCompilationUnit`, who may keep the last SourceFile
    instance. The default implementation does not cache anything, but
    `ScalaCompilationUnit` does.
    In the process, removed a number of `withSourceFile` methods on project
    and presentation compiler classes. These may break plugins.
    Fixed #1001859
Commits on Sep 2, 2013
  1. @dragos

    Mark output folders as "Derived".

    dragos authored
    Derived folders won't appear in "Open Resource", polluting
    names with classfiles.
    Fixes #1000260 (which regressed at some point in time).
Commits on May 31, 2013
  1. @dragos

    Use the configured JDK and Scala library when building.

    dragos authored
    Make sure the Sbt builder uses the configured JDK and
    Scala library. Make sure Sbt does not infer some default
    libraries for `-bootclasspath`, or the JDK used for running
    Fixed #1001387
Commits on Apr 30, 2013
  1. @dragos

    Don't force -Xprinttypes.

    dragos authored
    Fixed #1001677.
Commits on Apr 23, 2013
  1. @dragos @huitseeker

    Removed the Refined build manager.

    dragos authored huitseeker committed
    Fixes #1001422
Commits on Mar 25, 2013
  1. @dragos

    Avoid workspace-wide locks when building.

    dragos authored
    There is no reason to lock the workspace when building a project. Markers already
    lock the required resources, and the build should just lock the current project.
    Fixed #1001631.
Commits on Feb 11, 2013
  1. @dragos

    Initialize symbols for primitive types on compiler startup.

    dragos authored
    The nightly build uncovered a race condition in the indexer, that stepped on
    a case where `definitions.ShortClass` was not yet loaded, triggering the
    symbol loader.
    Needs back port. Should fix flaky presentation compiler tests.
Commits on Feb 7, 2013
  1. @dragos

    Merge pull request #297 from gzsombor/handle-exceptions-with-closed-p…

    dragos authored
    Add checks if the underlying project closed/not exists, and catch JavaMo...
Commits on Feb 5, 2013
  1. @dragos

    Rebuild Scala projects after a global compiler settings change.

    dragos authored
    If the user changes compiler settings on the Scala Preferences page, all Scala
    projects that 'inherit' these settings should be rebuild. The existing logic
    was dealing only with the case where *project-specific* settings were changed.
    Fixed #1001460.
Commits on Feb 4, 2013
  1. @dragos

    Remove `Xmigration28` setting.

    dragos authored
    Fixed build for 2.10.1-SNAPSHOT.
Commits on Dec 4, 2012
  1. @dragos

    Correctly update project settings when the preferences change.

    dragos authored
    The `PropertyStore` class is a snapshot, and during the move to sbt 0.13 the storage
    became a lazy-val, meaning we started to lose project settings.
    Fixed #1001241
    Fixed #1001267
Commits on Sep 2, 2012
  1. @dragos
Commits on Jul 27, 2012
  1. @dragos

    More abstract dealings with Scala compilation units.

    dragos authored
    We need a way to treat uniformly different kinds of Scala-based sources. Until now
    we routed everything through `ScalaCompilationUnit`, that extends the JDT `CompilationUnit`
    class. This tight connection is counter-productive, and in most cases, unnecessary.
    This commit is a step towards extracting a set of interfaces for other Scala-based
    sources to benefit of reconciliation ('errors-as-you-type'), hyperlinking and completion
    engine that already exists.
    * extracted `InteractiveCompilationUnit` as a super type of `ScalaCompilationUnit`
    * switched from `ScalaCompilationUnit` to `InteractiveCompilationUnit` wherever possible, to allow
    hyperlinking to work in the scala-worksheet project
    * added a utility method to retrieve the compilation unit associated with an open editor that
    uses the platform adapter protocol to allow other plugins to participate.
Commits on Jul 21, 2012
  1. @dragos

    Only react to part-closed events related to the current project.

    dragos authored
    This regression manifested by having a Scala compiler started on all Java projects when
    a file was closed. Annoyingly, that lead to the FailedCompilerInitialization window asking
    about adding the Scala library.
Commits on Jul 13, 2012
  1. @dragos

    Fixed warnings.

    dragos authored
    - catching `Throwable` (in 2.10 only). I tried to make sense of each case, and where safe replace `Throwable` by a smaller type. Not always possible
    - unchecked warnings (in one case it was completely wrong) in pattern matches
    - missing cases in a pattern match
Commits on Jul 11, 2012
  1. @dragos

    Don't report nonexistent projects in `directDependencies`. The JDT ha…

    dragos authored
    …s a very annoying habit of
    caching dependent projects, and there's no way to clear that cache. I've seen the build fail because it
    thought it depends on a nonexistent project. Neither closing, refreshing or restarting Eclipse helped,
    so we filter it explicitly here.
Commits on Jun 18, 2012
  1. @dragos

    Merge pull request #117 from dragos/issue/separate-runtime-compiletim…

    dragos authored
    Correct handling of source Scala libraries on the class path.
Commits on Jun 12, 2012
  1. @dragos

    Correct handling of source Scala libraries on the class path.

    dragos authored
    If a dependent project provides a Scala library as source, use the output directory
    as the bootclasspath for the current project.
    Don't filter out the Scala library from the class path. This allows compiling the Scala library itself.
Commits on May 24, 2012
  1. @dragos

    Extracted classpath management into its own trait.

    dragos authored
    Extended the logic for finding the Scala library in source folders, and not to rely on the 
    JDT (and implicitly the presentation compiler being present).
Commits on May 16, 2012
  1. @dragos

    Fixed deprecation warnings for things that are deprecated since 2.9.0…

    dragos authored
    … and may be removed in 2.10.
Commits on May 10, 2012
  1. @dragos

    Use the configured JDK when instantiating the presentation compiler.

    dragos authored
    The Scala compiler adds the currently running JDK to the class path, taking precedence over the JDK 
    configured in the build path. This commit fixed #1000820, and generalizes the scheme used by the Sbt
Commits on Apr 26, 2012
  1. @dragos
Commits on Feb 29, 2012
  1. @dragos
  2. @dragos
Commits on Feb 9, 2012
  1. @dragos

    Use File.pathSeparator when building the pluginsDir setting, to be pl…

    dragos authored
    …atform independent. Fixes #1000901.
Commits on Nov 21, 2011
  1. @dragos

    Better build error management, and cleaned up interactions between bu…

    dragos authored
    …ild, compiler settings,
    and class path validation errors.
    1. The class path validator deletes all Java and Scala error markers *only* when there is an
       class path error.
    2. Build errors, settings errors and class path errors have different marker IDs.
    3. Invalid setting errors are now reported. Until now they went unreported.
    4. Fixed #1000757.
Commits on Nov 7, 2011
  1. @dragos

    Copy resources to the output directory. This runs the JDT Java builde…

    dragos authored
    …r for this purpose, even when there are no modified Java files.
    Fixed #1000636.
Commits on Nov 4, 2011
  1. @dragos

    Integrated reviews.

    dragos authored Iulian Dragos committed
  2. @dragos

    Reworked the way the presentation compiler is restarted when projects…

    dragos authored Iulian Dragos committed
    … change.
    - A project resets the presentation compiler of all projects that depend on it after a successful build.
    - A project resets its own presentation compiler when one of the projects it depends on has changes (such as a class path change)
    - A class path change, or an added source file, restarts the PC
    Fixed #1000699. Test #1000645.
Commits on Nov 1, 2011
  1. @dragos
Something went wrong with that request. Please try again.