Permalink
Commits on Jul 20, 2011
  1. Updated the diagnostics dialog to use the new Scala Proposals categor…

    …y, instead of manipulating the java one. Removed the 'hack' that auto-enabled it when a project was open.
    dragos committed Jul 20, 2011
  2. removed comment

    dotta committed Jul 20, 2011
  3. Fixed #1000494. Problem was the Java editor was getting opened instea…

    …d of the Scala one, and hence it was not possible to set brakpoints. Using JDT aspect weaver to incercept the call to the EditorId string I was able to force Eclipse into using the Scala Editor.
    dotta committed Jul 20, 2011
Commits on Jul 19, 2011
  1. Added missing files.

    dragos committed Jul 19, 2011
  2. Enabled completion tests.

    dragos committed Jul 19, 2011
  3. Refactored completion code and split the non-UI and UI parts. This en…

    …ables easier testing in a headless environment. Adapted tests to run fine in headless mode.
    dragos committed Jul 19, 2011
Commits on Jul 18, 2011
  1. Created a separate completion category for Scala completions. This sh…

    …ould fix a load of problems when Java Proposals were disabled by the Mylyn plugin. Still todo: update the diagnostics window.
    dragos committed Jul 18, 2011
  2. Removed dead code.

    dragos committed Jul 18, 2011
  3. Removed CompletionTests from the junit suite. Currently the completio…

    …n tests have some dependency on UI components, which is a problem since the Jenkins integration server can't correctly handle it. I need to fix this.
    dotta committed Jul 18, 2011
  4. Create JUnit base class for testing completion in the IDE. The test c…

    …lass is rather complex and should be cleaned, however writing tests is relatively easy. The testing class uses Mockito frameworks, hence I added the dependency in the pom.xml, the MANIFEST.MF and the build.properties file.
    dotta committed Jul 18, 2011
  5. Moved out inner classes of ScalaCompletionProposalComputer so that th…

    …ey can be reused. This is a first step toward cleaning up the proposal computer class as it currently has too many responsabilities (creating the view model, filtering presentation compiler returned completion set, strategy for ordering the returned completion elemnents, and more).
    dotta committed Jul 18, 2011
Commits on Jul 15, 2011
  1. Fixed #1000475. Completion is now hopefully working reliably in almost

    all scenarios. Further, completion finally also works when using infix
    annotation! (e.g., List(1,2) for<ask completion> now
    works!)
    
    The fix consisted in avoiding calling 'askCompletion' inside the 
    generic 'askOption' (that accepts a closure). 
    
    The technical reasons seems that 'ask' sets 'interruptsEnabled' to
    false, and 'signalDone' will not even look at the result tree,
    therefore the targetPos will never match the resulting tree. It looks
    like anything that relies on getting a typedTreeAt inside an 'ask'
    will fail!
    dotta committed Jul 15, 2011
Commits on Jul 14, 2011
  1. Add depenency on Equinox weaving so that weaving bundles will be reso…

    …lved even if neither the JDT Weaving for Scala feature nor AJDT is installed.
    milessabin committed Jul 14, 2011
  2. Added utility method for running 'Runnable' in a workspace from a clo…

    …sure, and switched to using it in all the 5 places where anonymous classes were created for it.
    dragos committed Jul 14, 2011
Commits on Jul 13, 2011
  1. Automatically enable JavaProposals if they are disabled, when a Scala…

    … project is loaded.
    dragos committed Jul 13, 2011
  2. Fixed the Diagnostics dialog to update the completion proposal settin…

    …gs when the user chooses 'Use recommended settings'.
    dragos committed Jul 13, 2011
  3. Fixed #1000356. Correctly set breakpoints in traits coming from binar…

    …ies (with source attachments). There are still cases where breakpoints can't be set (private members of objects), and in the long run the whole machinery should be re-based on the presentation compiler, instead of relying on the JDT being able to recognize Java Elements off Scala source.
    dragos committed Jul 13, 2011
Commits on Jul 12, 2011
  1. Lower the memory consumption by pulling out the OverrideIndicators. B…

    …eing inner classes, they hold on to the outer pointer, which transitively holds on to the Scala compiler instance. At least the JavaIndicator class does not need it, so it became top-level.
    dragos committed Jul 12, 2011
  2. Fixed Typo in comment.

    dragos committed Jul 12, 2011
Commits on Jul 11, 2011
  1. Fixed #1000470. Fixed #1000413. Don't report <empty> package in index…

    …er and structure builder. Fixes crash in Java completions.
    dragos committed Jul 11, 2011
  2. Fixed #1000361. Hide errors coming from the Scala compiler when they …

    …refer to Java sources.
    dragos committed Jul 11, 2011