New option for Organize Imports to always omit/prepend the scala package #143

Merged
merged 1 commit into from Jul 6, 2012

Projects

None yet

3 participants

@misto
Owner
misto commented Jul 5, 2012

The default value is set to false, but that's up for discussion, as is the naming of the setting in the UI.

Fixes #1001127

@dotta dotta and 1 other commented on an outdated diff Jul 5, 2012
...tools/eclipse/refactoring/OrganizeImportsAction.scala
@@ -241,7 +241,13 @@ class OrganizeImportsAction extends RefactoringAction with ActionWithNoWizard {
val groups = getGroupsForProject(project).toList
- expandOrCollapse ::: List(wildcards, refactoring.SortImports, refactoring.GroupImports(groups))
+ val omitScalaPackage = if (shouldOmitScalaPackage(project)){
dotta
dotta Jul 5, 2012 Owner

maybe this should be renamed to scalaPackageStrategy? (I can't find a better name :( )

misto
misto Jul 5, 2012 Owner

Changed! It also fits better with the organizationStrategy above.

Owner
dotta commented Jul 5, 2012

lgtm

Owner
dotta commented Jul 5, 2012

By the way, so awesome to see all these "nice to have" features getting into master so quickly! :)

Owner
misto commented Jul 5, 2012

I'm just trying to get my number of open bugs down before going on vacation ;-)

Owner
misto commented Jul 5, 2012

Sorry Jenkins, but you'll have to try again tomorrow when a fresh nightly build of scala-refactoring is available.

Owner
misto commented Jul 6, 2012

PLS REBUILD ALL

@dotta dotta merged commit d8de93d into scala-ide:master Jul 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment