Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue no warning when the Scala library is a project in the workspace #149

Merged
merged 2 commits into from Jul 12, 2012

Conversation

Projects
None yet
3 participants
Owner

dragos commented Jul 11, 2012

This removes the need to add a dummy library.properties file in the Scala library project.

Effectively, we assume the version in a scala project defined inside the workspace is compatible.

Don't report nonexistent projects in `directDependencies`. The JDT ha…
…s a very annoying habit of

caching dependent projects, and there's no way to clear that cache. I've seen the build fail because it
thought it depends on a nonexistent project. Neither closing, refreshing or restarting Eclipse helped,
so we filter it explicitly here.

Should you also check for open projects? (maybe it's a silly question :))

Owner

dragos replied Jul 11, 2012

This was enough in my tests, so I will leave it as is for the moment. If there are closed dependent projects, the builder won't be called anyway, so I think this is safe.

Owner

dotta commented Jul 11, 2012

Looks good to me! And really love the new ScalaLibrary class ;)

Added a test for working with the Scala library coming from a file, a…
…nd made the

class path checker more lenient when the library comes from a project. In such a 
case the version is assumed to be compatible (there is no library.properties file 
inside the project, so we can't reliably guess the version).
Owner

dragos commented Jul 11, 2012

I force-pushed and fixed the test with some try-finally love. I'll merge once the build is successful.

Owner

dragos commented Jul 11, 2012

REBUILD ALL PLS

Owner

dragos commented Jul 11, 2012

PLS REBUILD ALL

dragos added a commit that referenced this pull request Jul 12, 2012

Merge pull request #149 from dragos/issue/no-warning-when-library-is-…
…project

Issue no warning when the Scala library is a project in the workspace

@dragos dragos merged commit 924c994 into scala-ide:master Jul 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment