Use the proper platform methods in the Scala launcher #229

Merged
merged 1 commit into from Nov 14, 2012

Projects

None yet

3 participants

@dragos
Member
dragos commented Nov 9, 2012

This is a small refactoring that improves a bit the Scala launcher:

  • the existence of the main class is checked in finalLaunchCheck, instead of inside launch
  • compilation errors are done through markers, and integrates with the platform error message. This check is also done during finalLaunchCheck and now prompts the user if any required project has compilation errors before launching.

Fixed #100740, possibly others. :)

@dragos dragos Use the proper platform methods in the Scala launcher
This is a small refactoring that improves a bit the Scala launcher:

* the existence of the main class is checked in `finalLaunchCheck`, instead of inside `launch`
* compilation errors are done through markers, and integrates with the platform error message. The check is
  also done during `finalLaunchCheck` and now prompts the user if any required project has compilation errors
  before launching.

Fixed #100740, possibly others.
c74dde4
@skyluc
Member
skyluc commented Nov 13, 2012

Otherwise, LGTM.

@dragos dragos merged commit 8a424af into scala-ide:master Nov 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment