``sbt.precompiled.version`` has to match ``scala.version`` #265

Merged
merged 1 commit into from Dec 17, 2012

Conversation

Projects
None yet
3 participants
Owner

dotta commented Dec 17, 2012

It is really important that when we build the IDE, the sbt artifacts are
compiled against the exact same Scala compiler that is shipped in the IDE. To
this end, I've updated the value of sbt.precompiled.version to always match
the scala.version one. This is needed because while the Scala library is
ensured to be forward binary compatible across minor releases, no such
guarantee is provided for the Scala compiler (and the Sbt compiler-interface,
which we use in the IDE, does need to be linked against the Scala compiler).

As part of this commit, I've also made another small change to the property
scala.major.minor.version and renamed it scala.era.major.version, as
this what this property actually contains.

pom.xml
</profile>
<profile>
<id>scala-2.10.x</id>
<properties>
<scala.version>2.10.0-SNAPSHOT</scala.version>
- <scala.major.minor.version>2.10</scala.major.minor.version>
<scala.library.version>${scala.version}</scala.library.version>
@dotta

dotta Dec 17, 2012

Owner

Oh, actually, this is not needed, because it's already defined like this in the inherithed, outer property: https://github.com/scala-ide/scala-ide/pull/265/files#L2R61

I'll simply remove it.

``sbt.precompiled.version`` has to match ``scala.version``
It is really important that when we build the IDE, the sbt artifacts are
compiled against the exact same Scala compiler that is shipped in the IDE. To
this end, I've updated the value of ``sbt.precompiled.version`` to always match
the ``scala.version`` one. This is needed because while the Scala library is
ensured to be forward binary compatible across minor releases, no such
guarantee is provided for the Scala compiler (and the Sbt compiler-interface,
which we use in the IDE, does need to be linked against the Scala compiler).

As part of this commit, I've also made another small change to the property
``scala.major.minor.version`` and renamed it ``scala.era.major.version``, as
this what this property actually contains.
Owner

dragos commented Dec 17, 2012

LGTM

dotta added a commit that referenced this pull request Dec 17, 2012

Merge pull request #265 from dotta/issue/sbt-artifacts
``sbt.precompiled.version`` has to match ``scala.version``

@dotta dotta merged commit eb61d7f into scala-ide:master Dec 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment