Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

``sbt.precompiled.version`` has to match ``scala.version`` #265

Merged
merged 1 commit into from

3 participants

@dotta
Owner

It is really important that when we build the IDE, the sbt artifacts are
compiled against the exact same Scala compiler that is shipped in the IDE. To
this end, I've updated the value of sbt.precompiled.version to always match
the scala.version one. This is needed because while the Scala library is
ensured to be forward binary compatible across minor releases, no such
guarantee is provided for the Scala compiler (and the Sbt compiler-interface,
which we use in the IDE, does need to be linked against the Scala compiler).

As part of this commit, I've also made another small change to the property
scala.major.minor.version and renamed it scala.era.major.version, as
this what this property actually contains.

pom.xml
((38 lines not shown))
</profile>
<profile>
<id>scala-2.10.x</id>
<properties>
<scala.version>2.10.0-SNAPSHOT</scala.version>
- <scala.major.minor.version>2.10</scala.major.minor.version>
<scala.library.version>${scala.version}</scala.library.version>
@dotta Owner
dotta added a note

Oh, actually, this is not needed, because it's already defined like this in the inherithed, outer property: https://github.com/scala-ide/scala-ide/pull/265/files#L2R61

I'll simply remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@dotta dotta ``sbt.precompiled.version`` has to match ``scala.version``
It is really important that when we build the IDE, the sbt artifacts are
compiled against the exact same Scala compiler that is shipped in the IDE. To
this end, I've updated the value of ``sbt.precompiled.version`` to always match
the ``scala.version`` one. This is needed because while the Scala library is
ensured to be forward binary compatible across minor releases, no such
guarantee is provided for the Scala compiler (and the Sbt compiler-interface,
which we use in the IDE, does need to be linked against the Scala compiler).

As part of this commit, I've also made another small change to the property
``scala.major.minor.version`` and renamed it ``scala.era.major.version``, as
this what this property actually contains.
f7b61eb
@dragos
Owner

LGTM

@dotta dotta merged commit eb61d7f into scala-ide:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 17, 2012
  1. @dotta

    ``sbt.precompiled.version`` has to match ``scala.version``

    dotta authored
    It is really important that when we build the IDE, the sbt artifacts are
    compiled against the exact same Scala compiler that is shipped in the IDE. To
    this end, I've updated the value of ``sbt.precompiled.version`` to always match
    the ``scala.version`` one. This is needed because while the Scala library is
    ensured to be forward binary compatible across minor releases, no such
    guarantee is provided for the Scala compiler (and the Sbt compiler-interface,
    which we use in the IDE, does need to be linked against the Scala compiler).
    
    As part of this commit, I've also made another small change to the property
    ``scala.major.minor.version`` and renamed it ``scala.era.major.version``, as
    this what this property actually contains.
This page is out of date. Refresh to see the latest.
Showing with 20 additions and 18 deletions.
  1. +1 −1  build-all.sh
  2. +1 −1  org.scala-ide.sdt.core/pom.xml
  3. +18 −16 pom.xml
View
2  build-all.sh
@@ -10,7 +10,7 @@ ROOT_DIR=${PWD}
if [ -z "$*" ]
then
- ARGS="clean install"
+ ARGS="-P scala-2.9.x clean install"
else
ARGS="$*"
fi
View
2  org.scala-ide.sdt.core/pom.xml
@@ -94,7 +94,7 @@
<goals><goal>add-source</goal></goals>
<configuration>
<sources>
- <source>src-${scala.major.minor.version}</source>
+ <source>src-${scala.era.major.version}</source>
</sources>
</configuration>
</execution>
View
34 pom.xml
@@ -55,33 +55,37 @@
<repo.eclipse>${repo.eclipse.indigo}</repo.eclipse>
<repo.ajdt>${repo.ajdt.indigo}</repo.ajdt>
- <!-- default values, can be overwritten by profiles -->
- <scala.version>2.9.3-SNAPSHOT</scala.version>
- <scala.major.minor.version>2.9</scala.major.minor.version>
- <scala.library.version>${scala.version}</scala.library.version>
- <sbt.compiled.version>2.9.2</sbt.compiled.version>
- <version.suffix>2_09</version.suffix>
- <version.tag>local</version.tag>
+ <!-- default values, can be overwritten by profiles -->
+ <scala.version>2.9.3-SNAPSHOT</scala.version>
+ <scala.era.major.version>2.9</scala.era.major.version>
+ <scala.library.version>${scala.version}</scala.library.version>
+ <sbt.compiled.version>${scala.version}</sbt.compiled.version>
+ <version.suffix>2_09</version.suffix>
+ <version.tag>local</version.tag>
<!-- the repos containing the Scala dependencies -->
- <repo.scala-refactoring>${repo.scala-ide.root}/scala-refactoring-29x</repo.scala-refactoring>
- <repo.scalariform>${repo.scala-ide.root}/scalariform-29x</repo.scalariform>
- <repo.typesafe>http://repo.typesafe.com/typesafe/ide-2.9</repo.typesafe>
+ <repo.scala-refactoring>Select a profile</repo.scala-refactoring>
+ <repo.scalariform>Select a profile</repo.scalariform>
+ <repo.typesafe>Select a profile</repo.typesafe>
+
</properties>
<profiles>
<profile>
<!--- the profile using the default values. Scala 2.9.x -->
<id>scala-2.9.x</id>
+ <properties>
+ <repo.scala-refactoring>${repo.scala-ide.root}/scala-refactoring-29x</repo.scala-refactoring>
+ <repo.scalariform>${repo.scala-ide.root}/scalariform-29x</repo.scalariform>
+ <repo.typesafe>http://repo.typesafe.com/typesafe/ide-2.9</repo.typesafe>
+ </properties>
</profile>
<profile>
<id>scala-2.10.x</id>
<properties>
<scala.version>2.10.0-SNAPSHOT</scala.version>
- <scala.major.minor.version>2.10</scala.major.minor.version>
- <scala.library.version>${scala.version}</scala.library.version>
- <sbt.compiled.version>2.10</sbt.compiled.version>
+ <scala.era.major.version>2.10</scala.era.major.version>
<version.suffix>2_10</version.suffix>
<repo.scala-refactoring>${repo.scala-ide.root}/scala-refactoring-210x</repo.scala-refactoring>
@@ -94,9 +98,7 @@
<id>scala-2.11.x</id>
<properties>
<scala.version>2.11.0-SNAPSHOT</scala.version>
- <scala.major.minor.version>2.11</scala.major.minor.version>
- <scala.library.version>${scala.version}</scala.library.version>
- <sbt.compiled.version>2.11</sbt.compiled.version>
+ <scala.era.major.version>2.11</scala.era.major.version>
<version.suffix>2_11</version.suffix>
<repo.scala-refactoring>${repo.scala-ide.root}/scala-refactoring-211x</repo.scala-refactoring>
Something went wrong with that request. Please try again.