Skip to content

Conversation

@tindzk
Copy link
Contributor

@tindzk tindzk commented Mar 8, 2015

No description provided.

@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

Actually, MDN says that both arguments are required. The default value should therefore be removed altogether.

@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

Note that the value put after = doesn't matter to the compiler in a JS facade. It only serves documentation purposes. So putting null there will not make the compiler add a null if you don't specify the second argument.

@tindzk
Copy link
Contributor Author

tindzk commented Mar 8, 2015

Ok, thanks for clearing this up. I updated the commit accordingly.

@sjrd
Copy link
Member

sjrd commented Mar 8, 2015

LGTM, thanks.

sjrd added a commit that referenced this pull request Mar 8, 2015
Node: Fix calls to insertBefore() with one argument
@sjrd sjrd merged commit f0a5a64 into scala-js:master Mar 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants