Skip to content

Conversation

@BastienClement
Copy link

PR #193 changed the disabled property on HTMLElement from Boolean to js.UndefOr[Boolean].

Actually, there is no disabled property defined on the HTMLElement interface:
https://html.spec.whatwg.org/multipage/dom.html#htmlelement

This property is instead defined on specific sub-interfaces. So far I found 9 of them in the one-page specification for HTML:

This pull requests moves the disabled property from HTMLElement to the 7 sub-interfaces already present and reverts its type to Boolean.

I stumbled upon this while trying to define a custom element (extending HTMLElement) that required a custom disabled property. The compiler is falsely complaining that "variable disabled cannot override a mutable variable" even no such variable actually exists.

@sjrd
Copy link
Member

sjrd commented Aug 18, 2016

LGTM, Thanks!

Sorry for the delay, I was on vacation.

@sjrd sjrd merged commit 114c55e into scala-js:master Aug 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants