Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newer firefox version needs geckodriver #62

Closed
schmitch opened this issue Oct 14, 2016 · 1 comment
Closed

Newer firefox version needs geckodriver #62

schmitch opened this issue Oct 14, 2016 · 1 comment
Assignees
@gzm0
Labels
bug
Milestone
v0.2.0

Comments

@schmitch
Copy link

schmitch commented Oct 14, 2016 •
edited

See: SeleniumHQ/selenium#2559

https://github.com/mozilla/geckodriver

It's basically the same thing as chromedriver.
gshakhn added a commit to gshakhn/private-wiki that referenced this issue Mar 16, 2017
@gshakhn
Drop support for running tests in Firefox.
4967548 
The latest version of Firefox (52.0 as of this commit) requires
selenium 3.x and geckodriver. scala-js-env-selenium depends on
selenium 2.53.0. scala-js/scala-js-env-selenium#62 should fix this.

Additionally, only firefox-esr is available in Debian Jessie (the OS
for the openjdk:8 image) repositories.

Could I install the latest firefox and figure out how to support it
with the current version of scala-js-env-selenium? Maybe.
Could I just install firefox-esr locally and use the existing
version of scala-js-env-selenium locally and in CI? Yes.
Do I care enough? No.
@gzm0 gzm0 added the bug label Jul 27, 2017
@gzm0 gzm0 self-assigned this Jul 27, 2017
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Improve external interface
70f5024 
Also make runner implementations private. This fixes scala-js#62 by requiring
the gecko driver.
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Fix CI
d72cfd7 
Note: This removes the keepAlive tests: The are too expensive for what
they are worth. Relying on killall to determine that there are no
processes around is too fragile. We should replace these tests by
unit-tests (scala-js#67).

This fixes scala-js#39 (chrome on ci) and scala-js#62 (use gecko driver).
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Fix CI
3b493a0 
Note: This removes the keepAlive tests: The are too expensive for what
they are worth. Relying on killall to determine that there are no
processes around is too fragile. We should replace these tests by
unit-tests (scala-js#67).

This fixes scala-js#39 (chrome on ci) and scala-js#62 (use gecko driver).
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Fix CI
7afb306 
Note: This removes the keepAlive tests: The are too expensive for what
they are worth. Relying on killall to determine that there are no
processes around is too fragile. We should replace these tests by
unit-tests (scala-js#67).

This fixes scala-js#39 (chrome on ci) and scala-js#62 (use gecko driver).
gzm0 added a commit to gzm0/scala-js-env-selenium that referenced this issue Jul 27, 2017
@gzm0
Fix CI
06d6877 
Note: This removes the keepAlive tests: The are too expensive for what
they are worth. Relying on killall to determine that there are no
processes around is too fragile. We should replace these tests by
unit-tests (scala-js#67).

This fixes scala-js#39 (chrome on ci) and scala-js#62 (use gecko driver).
@gzm0
Copy link
Contributor

gzm0 commented Jul 27, 2017

Fixed in 005c3d2

@gzm0 gzm0 closed this as completed Jul 27, 2017
@gzm0 gzm0 modified the milestone: v0.2.0 Jul 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
bug
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@gzm0 @schmitch