Skip to content

Conversation

@blakehawkins
Copy link
Contributor

@gzm0 gzm0 requested a review from sjrd August 3, 2022 13:22
@gzm0
Copy link
Contributor

gzm0 commented Aug 3, 2022

TY for the PR. I'm assigning this to @sjrd, because I'm not 100% familiar with how these links are used / generated (I'd like to avoid removing an existing, incorrect permalink accidentally).

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an appropriate redirect in
https://github.com/scala-js/scala-js-website/blob/main/.htaccess
in order not to break existing links elsewhere.

@blakehawkins
Copy link
Contributor Author

The existing link is already a 404 so I think this PR doesn't actually add any exposure as-is

I'm happy to add a permalink redirect in any fase

@blakehawkins blakehawkins requested a review from sjrd August 3, 2022 22:18
@sjrd
Copy link
Member

sjrd commented Aug 4, 2022

The existing URL https://www.scala-js.org/news/2020/11/16/announcing-scalajs-1.5.1/ is clearly not a 404. So if we move that page, we do need a redirect. 😉

@sjrd sjrd merged commit a4c2f1b into scala-js:main Aug 4, 2022
@blakehawkins
Copy link
Contributor Author

Yeah fair enough, assuming someone managed to get to that URI!

@gzm0
Copy link
Contributor

gzm0 commented Aug 4, 2022

It's very likely in a tweet somewhere :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants