-
Notifications
You must be signed in to change notification settings - Fork 148
Announcing Scala.js 1.11.0. #585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
74bf22d to
77366f4
Compare
gzm0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor things
| title: Announcing Scala.js 1.11.0 | ||
| category: news | ||
| tags: [releases] | ||
| permalink: /news/2021/12/10/announcing-scalajs-1.11.0/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong permalink?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, good catch!
| } | ||
| {% endhighlight %} | ||
|
|
||
| This may have significant performance impacts in fullLink, like other compliant behaviors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Performance impact (no s)?
| The initial value of the field, as well as any other assignments to it, are still evaluated for their side effects. | ||
| That code can only be removed if the optimizer can prove that it is pure. | ||
|
|
||
| ### The sbt setting `envVars` is taken into account |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I look at this: should this be under changes with compat concerns? A build might break if the jsenv refuses an existing setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that is a good point. I moved it and added a sentence about that.
77366f4 to
08467ed
Compare
No description provided.