Skip to content

Conversation

@viktor-podzigun
Copy link
Contributor

No description provided.

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Could you:

  • Revert the changes to .gitignore
  • Add a trailing newline character in the .svg file, to follow our convention everywhere

?

@viktor-podzigun
Copy link
Contributor Author

Revert the changes to .gitignore

Done!

Add a trailing newline character in the .svg file, to follow our convention everywhere

Weird, but it was copied from 1.11 file and the new line at the end is there, when you do view source:
Screenshot 2022-11-26 at 16 15 36

it is just GitHub PR viewer doesn't show it for some reason.

@viktor-podzigun viktor-podzigun requested a review from sjrd November 26, 2022 15:21
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@sjrd sjrd merged commit 1da9c42 into scala-js:main Nov 26, 2022
@viktor-podzigun viktor-podzigun deleted the add_1_12_badge branch November 26, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants