New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBT task name conflict prevents use with xsbt-web-plugin #1050

Closed
japgolly opened this Issue Sep 16, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@japgolly
Copy link
Contributor

japgolly commented Sep 16, 2014

Trying to use Scala.js and xsbt-web-plugin in the same project, SBT is unable to boot due to both plugins having a key named launcher.

java.lang.RuntimeException: Some keys were defined with the same name but different types: 'launcher' (sbt.Task[sbt.Attributed[scala.scalajs.tools.io.VirtualJSFile]], sbt.Task[scala.collection.Seq[java.lang.String]])
    at scala.sys.package$.error(package.scala:27)
    at sbt.Index$.stringToKeyMap0(EvaluateConfigurations.scala:279)
    at sbt.Index$.stringToKeyMap(EvaluateConfigurations.scala:270)
    at sbt.Load$.structureIndex(Load.scala:180)
    at sbt.Load$.apply(Load.scala:137)
    at sbt.Load$.defaultLoad(Load.scala:36)
    at sbt.BuiltinCommands$.doLoadProject(Main.scala:481)
    at sbt.BuiltinCommands$$anonfun$loadProjectImpl$2.apply(Main.scala:475)
    at sbt.BuiltinCommands$$anonfun$loadProjectImpl$2.apply(Main.scala:475)
    at sbt.Command$$anonfun$applyEffect$1$$anonfun$apply$2.apply(Command.scala:58)
    at sbt.Command$$anonfun$applyEffect$1$$anonfun$apply$2.apply(Command.scala:58)
    at sbt.Command$$anonfun$applyEffect$2$$anonfun$apply$3.apply(Command.scala:60)
    at sbt.Command$$anonfun$applyEffect$2$$anonfun$apply$3.apply(Command.scala:60)
    at sbt.Command$.process(Command.scala:92)
    at sbt.MainLoop$$anonfun$1$$anonfun$apply$1.apply(MainLoop.scala:98)
    at sbt.MainLoop$$anonfun$1$$anonfun$apply$1.apply(MainLoop.scala:98)
    at sbt.State$$anon$1.process(State.scala:184)
    at sbt.MainLoop$$anonfun$1.apply(MainLoop.scala:98)
    at sbt.MainLoop$$anonfun$1.apply(MainLoop.scala:98)
    at sbt.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
    at sbt.MainLoop$.next(MainLoop.scala:98)
    at sbt.MainLoop$.run(MainLoop.scala:91)
    at sbt.MainLoop$$anonfun$runWithNewLog$1.apply(MainLoop.scala:70)
    at sbt.MainLoop$$anonfun$runWithNewLog$1.apply(MainLoop.scala:65)
    at sbt.Using.apply(Using.scala:24)
    at sbt.MainLoop$.runWithNewLog(MainLoop.scala:65)
    at sbt.MainLoop$.runAndClearLast(MainLoop.scala:48)
    at sbt.MainLoop$.runLoggedLoop(MainLoop.scala:32)
    at sbt.MainLoop$.runLogged(MainLoop.scala:24)
    at sbt.StandardMain$.runManaged(Main.scala:53)
    at sbt.xMain.run(Main.scala:28)
    at xsbt.boot.Launch$$anonfun$run$1.apply(Launch.scala:109)
    at xsbt.boot.Launch$.withContextLoader(Launch.scala:129)
    at xsbt.boot.Launch$.run(Launch.scala:109)
    at xsbt.boot.Launch$$anonfun$apply$1.apply(Launch.scala:36)
    at xsbt.boot.Launch$.launch(Launch.scala:117)
    at xsbt.boot.Launch$.apply(Launch.scala:19)
    at xsbt.boot.Boot$.runImpl(Boot.scala:44)
    at xsbt.boot.Boot$.main(Boot.scala:20)
    at xsbt.boot.Boot.main(Boot.scala)
@japgolly

This comment has been minimized.

Copy link
Contributor

japgolly commented Sep 16, 2014

Cross-linking issues: earldouglas/xsbt-web-plugin#189

@sjrd

This comment has been minimized.

Copy link
Member

sjrd commented Sep 16, 2014

Ah. This is embarrassing. I suppose we'll have to make our keys more specific, probably by prefixing them systematically with scalaJS.
We might have to schedule this to 0.6.0, since it impacts existing build files. But I'll tentatively assign it to 0.5.5.

@sjrd sjrd added the bug label Sep 16, 2014

@sjrd sjrd added this to the v0.5.5 milestone Sep 16, 2014

@sjrd sjrd self-assigned this Sep 16, 2014

@sjrd sjrd closed this in 779558f Sep 16, 2014

gzm0 added a commit that referenced this issue Sep 16, 2014

Merge pull request #1053 from sjrd/prefix-setting-names
Fix #1050: Fix one known and some potential setting name conflicts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment