Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine compatibility guarantees and naming of irio package #3656

Closed
gzm0 opened this issue May 19, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@gzm0
Copy link
Contributor

commented May 19, 2019

Ideally, we would have a way to make changes to some of the lower level APIs (notably WritableVirtualBinaryFile).

However, some other parts definitely need to be super-stable, as they are required to link (and mentioned in the other parts of the super stable API).

@gzm0 gzm0 added this to the v1.0.0-M8 milestone May 19, 2019

@gzm0 gzm0 self-assigned this May 19, 2019

@gzm0 gzm0 added the enhancement label May 19, 2019

@gzm0 gzm0 referenced this issue May 19, 2019

Closed

Simplify VirtualFile API #3330

9 of 9 tasks complete
@sjrd

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Even WritableVirtualBinaryFile is referenced by the super-stable API in LinkerOutput. As far as I can tell, everything in irio needs to be super-stable. Isn't that the case?

@gzm0

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

Yes. But I'd like it not to. So I'm considering providing factories for commonly used WritableVirtualBinaryFiles that are super stable but making the interface with it less stable.

In other words, if you implement your own WritableVirtualBinaryFile, you have to expect breakages. If you use one that is provided by us, we'll do that for you.

@sjrd

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Ah, I see. Yes, I guess that makes sense, indeed.

@sjrd sjrd modified the milestones: v1.0.0-M8, v1.0.0-M9 May 31, 2019

@sjrd sjrd closed this in 5d6b4ba Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.