Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Logger cleanups #3553

merged 3 commits into from Jan 31, 2019


Copy link

commented Jan 30, 2019

No description provided.

gzm0 added 3 commits Jan 30, 2019
Remove Logger.success
It is unused.
Clean-up ScalaConsoleLogger code
- Use pattern match instead of nested if.
- Align with coding style.

@gzm0 gzm0 requested a review from sjrd Jan 30, 2019

sjrd approved these changes Jan 30, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Jan 31, 2019

Jenkins retest this please

@sjrd sjrd merged commit c2e3797 into scala-js:master Jan 31, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/jenkins/pr-merge This commit looks good

@gzm0 gzm0 deleted the gzm0:clean-logger branch Jan 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.