Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile no longer needs cre2 #1663

Closed
LeeTibbert opened this issue Jul 23, 2019 · 1 comment
Closed

Dockerfile no longer needs cre2 #1663

LeeTibbert opened this issue Jul 23, 2019 · 1 comment
Labels
component:build
Milestone
0.4.0

Comments

@LeeTibbert
Copy link
Contributor

Whilst chasing other issues, I noticed that ci-docker/Dockerfile still installs the
cre2 regex library.

This remnant of cre2 is (almost) harmless but adds a bit of misdirection.
The change fro:
RUN apt-get update && apt-get install -y clang-5.0 zlib1g-dev libgc-dev libre2-dev
to:
RUN apt-get update && apt-get install -y clang-5.0 zlib1g-dev libgc-dev
should be as easy as anything gets but I suspect complexity lurks.

I will ask on gitter if the Docker container needs to rebuilt or anything.
@densh densh closed this as completed in 3dbd572 Jul 25, 2019
@densh densh added this to the 0.4.0-M3 milestone Jul 25, 2019
@LeeTibbert
Copy link
Contributor Author

Information which might be of use to anybody considering editing the Dockerfile in
the future.

The resolution of my Dockerfile change concerns is that there is no need to
do anything special. Travis CI picks up the new Dockerfile, does the rebuild itself,
and executes with the new image.

Somebody or somebodies (@shadaj ?) did nice, devo friendly work! Thank you.

I had to examine the Travis CI logfile in detail to find the place where the Dockerfile
is rebuilt. For me it ended up with a line prefixed "15/21". Your "m/n" may vary but
that format may help narrow your search.

ekrich pushed a commit to ekrich/scala-native that referenced this issue May 21, 2021
@LeeTibbert @ekrich
Fix scala-native#1663: Dockerfile no longer needs cre2 (scala-native#…
b82b8d8 
…1668)

* This PR fixes Issue "Dockerfile no longer needs cre2".

  The library libre2-dev is no longer installed. As of SN 0.4.0,
  SN uses re2s instead of cre2.

Documentation:

* None needed: not a user facing change & relevant devos notified.

Testing:

* I know of know way to test this on my system.  Attempting a
  crash & burn test on Travis CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:build
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@densh @LeeTibbert