Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posixlib times method needs more validation #3088

Open
LeeTibbert opened this issue Jan 12, 2023 · 0 comments
Open

Posixlib times method needs more validation #3088

LeeTibbert opened this issue Jan 12, 2023 · 0 comments

Comments

@LeeTibbert
Copy link
Contributor

PR #3087 modifies TimesTest so that it does not fail CI when times() returns a zero
user or system process time. I can not find any obvious error in the implementation
of posixlib times() but I do not trust it. I believe that it needs more validation.

That validation probably needs to be done manually, so that it does not cause
CI to intermittently fail. It probably needs to be in a sandbox project in order
to have better visibility of the actual reported user cpu times and better
control/expectation of what 'reasonable' values should be. Right now,
they are tested for 1) changed & 2) non-negative. I suspect the reported
values are way smaller than one would expect. No proof, though.

I am capturing this experience in an Issue in case others use times() and
get weird/wrong values.

After a good manual Test or Tests are created, perhaps they could be
folded into CI. Or perhaps they need to remain manual.

A good project to peck away at whilst waiting for other PRs to clear CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant