Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1606: Add printf vararg helpers #1636

Merged
merged 4 commits into from Jul 6, 2019

Conversation

rwhaling
Copy link
Contributor

Adds a libc package object, which provides CVarArg* wrappers around stdio for the printf/scanf family of functions, which are incompatible with new interop in their previous form.

@ekrich
Copy link
Member

ekrich commented Jun 26, 2019

@rwhaling Looks like it needs some scalafmt love.

ekrich
ekrich approved these changes Jul 5, 2019
Copy link
Member

@ekrich ekrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@densh
Copy link
Member

densh commented Jul 5, 2019

LGTM, thanks @rwhaling ! 👍

densh
densh approved these changes Jul 6, 2019
@densh densh merged commit 10e8adf into scala-native:master Jul 6, 2019
ekrich pushed a commit to ekrich/scala-native that referenced this pull request May 21, 2021
* added libc package object with printf etc vararg wrappers

* ran scalafmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants