Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commix: named semaphores #1658

merged 2 commits into from Jul 29, 2019


Copy link

@valdisxp1 valdisxp1 commented Jul 20, 2019

Using named semaphores only for comparability with MacOs see #1654 .
Needs changes from #1657 to compile on Mac.

  • tested on Linux
  • tested on MacOs

Copy link

lolgab commented Jul 20, 2019

Tried on my Mac machine and it links nicely now.

Copy link

@densh densh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also needs a rebase due conflicting changes in the other PR.

nativelib/src/main/resources/gc/commix/Phase.c Outdated Show resolved Hide resolved
Copy link

densh commented Jul 29, 2019

LGTM, thanks @valdisxp1 ! 👍

@densh densh merged commit e081886 into scala-native:master Jul 29, 2019
ekrich pushed a commit to ekrich/scala-native that referenced this pull request May 21, 2021
Using named semaphores only for comparability with MacOs see scala-native#1654.
Needs changes from scala-native#1657 to compile on Mac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants